Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on #408334 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 8 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 9 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_navigator_params.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
10 #include "chrome/test/base/in_process_browser_test.h" 14 #include "chrome/test/base/in_process_browser_test.h"
11 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "content/public/test/browser_test_utils.h"
12 #include "net/test/embedded_test_server/embedded_test_server.h" 17 #include "net/test/embedded_test_server/embedded_test_server.h"
13 18
14 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { 19 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
15 public: 20 public:
16 MetricsWebContentsObserverBrowserTest() {} 21 MetricsWebContentsObserverBrowserTest() {}
17 ~MetricsWebContentsObserverBrowserTest() override {} 22 ~MetricsWebContentsObserverBrowserTest() override {}
18 23
19 protected: 24 protected:
20 void NavigateToUntrackedUrl() { 25 void NavigateToUntrackedUrl() {
21 ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)); 26 ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL));
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 ASSERT_TRUE(embedded_test_server()->Start()); 219 ASSERT_TRUE(embedded_test_server()->Start());
215 220
216 ui_test_utils::NavigateToURL( 221 ui_test_utils::NavigateToURL(
217 browser(), embedded_test_server()->GetURL( 222 browser(), embedded_test_server()->GetURL(
218 "/page_load_metrics/document_write_no_script.html")); 223 "/page_load_metrics/document_write_no_script.html"));
219 NavigateToUntrackedUrl(); 224 NavigateToUntrackedUrl();
220 225
221 histogram_tester_.ExpectTotalCount( 226 histogram_tester_.ExpectTotalCount(
222 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 227 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
223 } 228 }
229
230 // Test code that aborts provisional navigations.
231 // TODO(csharrison): Move these to unit tests once the navigation API in content
232 // properly calls NavigationHandle/NavigationThrottle methods.
233 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
234 AbortNewNavigation) {
235 ASSERT_TRUE(embedded_test_server()->Start());
236
237 GURL url(embedded_test_server()->GetURL("/title1.html"));
238 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
239 content::TestNavigationManager manager(
240 browser()->tab_strip_model()->GetActiveWebContents(), url);
241
242 chrome::Navigate(&params);
243 EXPECT_TRUE(manager.WaitForWillStartRequest());
244
245 GURL url2(embedded_test_server()->GetURL("/title2.html"));
246 chrome::NavigateParams params2(browser(), url2,
247 ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
248 content::TestNavigationManager manager2(
249 browser()->tab_strip_model()->GetActiveWebContents(), url2);
250 chrome::Navigate(&params2);
251
252 manager2.WaitForNavigationFinished();
253 histogram_tester_.ExpectTotalCount(
254 internal::kHistogramAbortNewNavigationBeforeCommit, 1);
255 }
256
257 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortReload) {
258 ASSERT_TRUE(embedded_test_server()->Start());
259
260 GURL url(embedded_test_server()->GetURL("/title1.html"));
261 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
262 content::TestNavigationManager manager(
263 browser()->tab_strip_model()->GetActiveWebContents(), url);
264
265 chrome::Navigate(&params);
266 EXPECT_TRUE(manager.WaitForWillStartRequest());
267
268 chrome::NavigateParams params2(browser(), url, ui::PAGE_TRANSITION_RELOAD);
269 content::TestNavigationManager manager2(
270 browser()->tab_strip_model()->GetActiveWebContents(), url);
271 chrome::Navigate(&params2);
272
273 manager2.WaitForNavigationFinished();
274 histogram_tester_.ExpectTotalCount(
275 internal::kHistogramAbortReloadBeforeCommit, 1);
276 }
277
278 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortClose) {
279 ASSERT_TRUE(embedded_test_server()->Start());
280
281 GURL url(embedded_test_server()->GetURL("/title1.html"));
282 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
283 content::TestNavigationManager manager(
284 browser()->tab_strip_model()->GetActiveWebContents(), url);
285
286 chrome::Navigate(&params);
287 EXPECT_TRUE(manager.WaitForWillStartRequest());
288
289 browser()->tab_strip_model()->GetActiveWebContents()->Close();
290
291 manager.WaitForNavigationFinished();
292
293 histogram_tester_.ExpectTotalCount(internal::kHistogramAbortCloseBeforeCommit,
294 1);
295 }
296
297 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortMultiple) {
298 ASSERT_TRUE(embedded_test_server()->Start());
299
300 GURL url(embedded_test_server()->GetURL("/title1.html"));
301 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
302 content::TestNavigationManager manager(
303 browser()->tab_strip_model()->GetActiveWebContents(), url);
304
305 chrome::Navigate(&params);
306 EXPECT_TRUE(manager.WaitForWillStartRequest());
307
308 GURL url2(embedded_test_server()->GetURL("/title2.html"));
309 chrome::NavigateParams params2(browser(), url2, ui::PAGE_TRANSITION_TYPED);
310 content::TestNavigationManager manager2(
311 browser()->tab_strip_model()->GetActiveWebContents(), url2);
312 chrome::Navigate(&params2);
313
314 EXPECT_TRUE(manager2.WaitForWillStartRequest());
315 manager.WaitForNavigationFinished();
316
317 GURL url3(embedded_test_server()->GetURL("/title3.html"));
318 chrome::NavigateParams params3(browser(), url3, ui::PAGE_TRANSITION_TYPED);
319 content::TestNavigationManager manager3(
320 browser()->tab_strip_model()->GetActiveWebContents(), url3);
321 chrome::Navigate(&params3);
322
323 EXPECT_TRUE(manager3.WaitForWillStartRequest());
324 manager2.WaitForNavigationFinished();
325
326 manager3.WaitForNavigationFinished();
327
328 histogram_tester_.ExpectTotalCount(
329 internal::kHistogramAbortNewNavigationBeforeCommit, 2);
330 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698