Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clamy@ review Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 8 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 9 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_navigator_params.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
10 #include "chrome/test/base/in_process_browser_test.h" 14 #include "chrome/test/base/in_process_browser_test.h"
11 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "content/public/test/browser_test_utils.h"
12 #include "net/test/embedded_test_server/embedded_test_server.h" 17 #include "net/test/embedded_test_server/embedded_test_server.h"
13 18
14 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { 19 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
15 public: 20 public:
16 MetricsWebContentsObserverBrowserTest() {} 21 MetricsWebContentsObserverBrowserTest() {}
17 ~MetricsWebContentsObserverBrowserTest() override {} 22 ~MetricsWebContentsObserverBrowserTest() override {}
18 23
19 protected: 24 protected:
20 void NavigateToUntrackedUrl() { 25 void NavigateToUntrackedUrl() {
21 ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL)); 26 ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL));
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 ASSERT_TRUE(embedded_test_server()->Start()); 220 ASSERT_TRUE(embedded_test_server()->Start());
216 221
217 ui_test_utils::NavigateToURL( 222 ui_test_utils::NavigateToURL(
218 browser(), embedded_test_server()->GetURL( 223 browser(), embedded_test_server()->GetURL(
219 "/page_load_metrics/document_write_no_script.html")); 224 "/page_load_metrics/document_write_no_script.html"));
220 NavigateToUntrackedUrl(); 225 NavigateToUntrackedUrl();
221 226
222 histogram_tester_.ExpectTotalCount( 227 histogram_tester_.ExpectTotalCount(
223 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 228 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
224 } 229 }
230
231 // Test code that aborts provisional navigations.
232 // TODO(csharrison): Move these to unit tests once the navigation API in content
233 // properly calls NavigationHandle/NavigationThrottle methods.
234 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
235 AbortNewNavigation) {
236 ASSERT_TRUE(embedded_test_server()->Start());
237
238 GURL url(embedded_test_server()->GetURL("/title1.html"));
239 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
240 content::TestNavigationManager manager(
241 browser()->tab_strip_model()->GetActiveWebContents(), url);
242
243 chrome::Navigate(&params);
244 manager.WaitForWillStartRequest();
245
246 GURL url2(embedded_test_server()->GetURL("/title2.html"));
247 chrome::NavigateParams params2(browser(), url2,
248 ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
249 content::TestNavigationManager manager2(
250 browser()->tab_strip_model()->GetActiveWebContents(), url2);
251 chrome::Navigate(&params2);
252
253 manager2.WaitForNavigationFinished();
254 histogram_tester_.ExpectTotalCount(
255 internal::kHistogramAbortNewNavigationBeforeCommit, 1);
256 }
257
258 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortReload) {
259 ASSERT_TRUE(embedded_test_server()->Start());
260
261 GURL url(embedded_test_server()->GetURL("/title1.html"));
262 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
263 content::TestNavigationManager manager(
264 browser()->tab_strip_model()->GetActiveWebContents(), url);
265
266 chrome::Navigate(&params);
267 manager.WaitForWillStartRequest();
268
269 chrome::NavigateParams params2(browser(), url, ui::PAGE_TRANSITION_RELOAD);
270 content::TestNavigationManager manager2(
271 browser()->tab_strip_model()->GetActiveWebContents(), url);
272 chrome::Navigate(&params2);
273
274 manager2.WaitForNavigationFinished();
275 histogram_tester_.ExpectTotalCount(
276 internal::kHistogramAbortReloadBeforeCommit, 1);
277 }
278
279 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortClose) {
280 ASSERT_TRUE(embedded_test_server()->Start());
281
282 GURL url(embedded_test_server()->GetURL("/title1.html"));
283 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
284 content::TestNavigationManager manager(
285 browser()->tab_strip_model()->GetActiveWebContents(), url);
286
287 chrome::Navigate(&params);
288 manager.WaitForWillStartRequest();
289
290 browser()->tab_strip_model()->GetActiveWebContents()->Close();
291
292 manager.WaitForNavigationFinished();
293
294 histogram_tester_.ExpectTotalCount(internal::kHistogramAbortCloseBeforeCommit,
295 1);
296 }
297
298 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortMultiple) {
299 ASSERT_TRUE(embedded_test_server()->Start());
300
301 GURL url(embedded_test_server()->GetURL("/title1.html"));
302 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
303 content::TestNavigationManager manager(
304 browser()->tab_strip_model()->GetActiveWebContents(), url);
305
306 chrome::Navigate(&params);
307 manager.WaitForWillStartRequest();
308
309 GURL url2(embedded_test_server()->GetURL("/title2.html"));
310 chrome::NavigateParams params2(browser(), url2, ui::PAGE_TRANSITION_TYPED);
311 content::TestNavigationManager manager2(
312 browser()->tab_strip_model()->GetActiveWebContents(), url2);
313 chrome::Navigate(&params2);
314
315 manager2.WaitForWillStartRequest();
316 manager.WaitForNavigationFinished();
317
318 GURL url3(embedded_test_server()->GetURL("/title3.html"));
319 chrome::NavigateParams params3(browser(), url3, ui::PAGE_TRANSITION_TYPED);
320 content::TestNavigationManager manager3(
321 browser()->tab_strip_model()->GetActiveWebContents(), url3);
322 chrome::Navigate(&params3);
323
324 manager3.WaitForWillStartRequest();
325 manager2.WaitForNavigationFinished();
326
327 manager3.WaitForNavigationFinished();
328
329 histogram_tester_.ExpectTotalCount(
330 internal::kHistogramAbortNewNavigationBeforeCommit, 2);
331 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698