Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Attach the throttle first so it gets all notifications before any DEFERs Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 8 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 9 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_navigator_params.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
10 #include "chrome/test/base/in_process_browser_test.h" 14 #include "chrome/test/base/in_process_browser_test.h"
11 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "content/public/test/browser_test_utils.h"
12 #include "net/test/embedded_test_server/embedded_test_server.h" 17 #include "net/test/embedded_test_server/embedded_test_server.h"
13 18
14 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { 19 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
15 public: 20 public:
16 MetricsWebContentsObserverBrowserTest() {} 21 MetricsWebContentsObserverBrowserTest() {}
17 ~MetricsWebContentsObserverBrowserTest() override {} 22 ~MetricsWebContentsObserverBrowserTest() override {}
18 23
19 protected: 24 protected:
20 base::HistogramTester histogram_tester_; 25 base::HistogramTester histogram_tester_;
21 26
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 231
227 ui_test_utils::NavigateToURL( 232 ui_test_utils::NavigateToURL(
228 browser(), embedded_test_server()->GetURL( 233 browser(), embedded_test_server()->GetURL(
229 "/page_load_metrics/document_write_no_script.html")); 234 "/page_load_metrics/document_write_no_script.html"));
230 ui_test_utils::NavigateToURL(browser(), 235 ui_test_utils::NavigateToURL(browser(),
231 embedded_test_server()->GetURL("/title2.html")); 236 embedded_test_server()->GetURL("/title2.html"));
232 237
233 histogram_tester_.ExpectTotalCount( 238 histogram_tester_.ExpectTotalCount(
234 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 239 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
235 } 240 }
241
242 // Test code that aborts provisional navigations.
243 // TODO(csharrison): Move these to unit tests once the navigation API in content
244 // properly calls NavigationHandle/NavigationThrottle methods.
245 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
246 AbortNewNavigation) {
247 ASSERT_TRUE(embedded_test_server()->Start());
248
249 GURL url(embedded_test_server()->GetURL("/title1.html"));
250 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
251 content::TestNavigationManager manager(
252 browser()->tab_strip_model()->GetActiveWebContents(), url);
253
254 chrome::Navigate(&params);
255 manager.WaitForWillStartRequest();
256
257 GURL url2(embedded_test_server()->GetURL("/title2.html"));
258 chrome::NavigateParams params2(browser(), url2,
259 ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
260 content::TestNavigationManager manager2(
261 browser()->tab_strip_model()->GetActiveWebContents(), url2);
262 chrome::Navigate(&params2);
263
264 manager2.WaitForNavigationFinished();
265 histogram_tester_.ExpectTotalCount(
266 internal::kHistogramAbortNewNavigationBeforeCommit, 1);
267 }
268
269 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortReload) {
270 ASSERT_TRUE(embedded_test_server()->Start());
271
272 GURL url(embedded_test_server()->GetURL("/title1.html"));
273 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
274 content::TestNavigationManager manager(
275 browser()->tab_strip_model()->GetActiveWebContents(), url);
276
277 chrome::Navigate(&params);
278 manager.WaitForWillStartRequest();
279
280 chrome::NavigateParams params2(browser(), url, ui::PAGE_TRANSITION_RELOAD);
281 content::TestNavigationManager manager2(
282 browser()->tab_strip_model()->GetActiveWebContents(), url);
283 chrome::Navigate(&params2);
284
285 manager2.WaitForNavigationFinished();
286 histogram_tester_.ExpectTotalCount(
287 internal::kHistogramAbortReloadBeforeCommit, 1);
288 }
289
290 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortClose) {
291 ASSERT_TRUE(embedded_test_server()->Start());
292
293 GURL url(embedded_test_server()->GetURL("/title1.html"));
294 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
295 content::TestNavigationManager manager(
296 browser()->tab_strip_model()->GetActiveWebContents(), url);
297
298 chrome::Navigate(&params);
299 manager.WaitForWillStartRequest();
300
301 browser()->tab_strip_model()->GetActiveWebContents()->Close();
302
303 manager.WaitForNavigationFinished();
304
305 histogram_tester_.ExpectTotalCount(internal::kHistogramAbortCloseBeforeCommit,
306 1);
307 }
308
309 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortMultiple) {
310 ASSERT_TRUE(embedded_test_server()->Start());
311
312 GURL url(embedded_test_server()->GetURL("/title1.html"));
313 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
314 content::TestNavigationManager manager(
315 browser()->tab_strip_model()->GetActiveWebContents(), url);
316
317 chrome::Navigate(&params);
318 manager.WaitForWillStartRequest();
319
320 GURL url2(embedded_test_server()->GetURL("/title2.html"));
321 chrome::NavigateParams params2(browser(), url2, ui::PAGE_TRANSITION_TYPED);
322 content::TestNavigationManager manager2(
323 browser()->tab_strip_model()->GetActiveWebContents(), url2);
324 chrome::Navigate(&params2);
325
326 manager2.WaitForWillStartRequest();
327 manager.WaitForNavigationFinished();
328
329 GURL url3(embedded_test_server()->GetURL("/title3.html"));
330 chrome::NavigateParams params3(browser(), url3, ui::PAGE_TRANSITION_TYPED);
331 content::TestNavigationManager manager3(
332 browser()->tab_strip_model()->GetActiveWebContents(), url3);
333 chrome::Navigate(&params3);
334
335 manager3.WaitForWillStartRequest();
336 manager2.WaitForNavigationFinished();
337
338 manager3.WaitForNavigationFinished();
339
340 histogram_tester_.ExpectTotalCount(
341 internal::kHistogramAbortNewNavigationBeforeCommit, 2);
342 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698