Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a NavigationThrottle to help track provisional abort metrics Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 8 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 9 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_navigator_params.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
10 #include "chrome/test/base/in_process_browser_test.h" 14 #include "chrome/test/base/in_process_browser_test.h"
11 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "content/public/test/browser_test_utils.h"
12 #include "net/test/embedded_test_server/embedded_test_server.h" 17 #include "net/test/embedded_test_server/embedded_test_server.h"
13 18
14 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { 19 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
15 public: 20 public:
16 MetricsWebContentsObserverBrowserTest() {} 21 MetricsWebContentsObserverBrowserTest() {}
17 ~MetricsWebContentsObserverBrowserTest() override {} 22 ~MetricsWebContentsObserverBrowserTest() override {}
18 23
19 protected: 24 protected:
20 base::HistogramTester histogram_tester_; 25 base::HistogramTester histogram_tester_;
21 26
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 229
225 ui_test_utils::NavigateToURL( 230 ui_test_utils::NavigateToURL(
226 browser(), embedded_test_server()->GetURL( 231 browser(), embedded_test_server()->GetURL(
227 "/page_load_metrics/document_write_no_script.html")); 232 "/page_load_metrics/document_write_no_script.html"));
228 ui_test_utils::NavigateToURL(browser(), 233 ui_test_utils::NavigateToURL(browser(),
229 embedded_test_server()->GetURL("/title2.html")); 234 embedded_test_server()->GetURL("/title2.html"));
230 235
231 histogram_tester_.ExpectTotalCount( 236 histogram_tester_.ExpectTotalCount(
232 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 237 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
233 } 238 }
239
240 // Test code that aborts provisional navigations.
241 // TODO(csharrison): Move these to unit tests once the navigation API in content
242 // properly calls NavigationHandle/NavigationThrottle methods.
243 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
244 AbortNewNavigation) {
245 ASSERT_TRUE(embedded_test_server()->Start());
246
247 GURL url(embedded_test_server()->GetURL("/title1.html"));
248 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
249 content::TestNavigationManager manager(
250 browser()->tab_strip_model()->GetActiveWebContents(), url);
251
252 chrome::Navigate(&params);
253 manager.WaitForWillStartRequest();
254
255 GURL url2(embedded_test_server()->GetURL("/title2.html"));
256 chrome::NavigateParams params2(browser(), url2,
257 ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
258 content::TestNavigationManager manager2(
259 browser()->tab_strip_model()->GetActiveWebContents(), url2);
260 chrome::Navigate(&params2);
261
262 manager2.WaitForNavigationFinished();
263 histogram_tester_.ExpectTotalCount(
264 internal::kHistogramAbortNewNavigationBeforeCommit, 1);
265 }
266
267 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortReload) {
268 ASSERT_TRUE(embedded_test_server()->Start());
269
270 GURL url(embedded_test_server()->GetURL("/title1.html"));
271 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
272 content::TestNavigationManager manager(
273 browser()->tab_strip_model()->GetActiveWebContents(), url);
274
275 chrome::Navigate(&params);
276 manager.WaitForWillStartRequest();
277
278 chrome::NavigateParams params2(browser(), url, ui::PAGE_TRANSITION_RELOAD);
279 content::TestNavigationManager manager2(
280 browser()->tab_strip_model()->GetActiveWebContents(), url);
281 chrome::Navigate(&params2);
282
283 manager2.WaitForNavigationFinished();
284 histogram_tester_.ExpectTotalCount(
285 internal::kHistogramAbortReloadBeforeCommit, 1);
286 }
287
288 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortClose) {
289 ASSERT_TRUE(embedded_test_server()->Start());
290
291 GURL url(embedded_test_server()->GetURL("/title1.html"));
292 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
293 content::TestNavigationManager manager(
294 browser()->tab_strip_model()->GetActiveWebContents(), url);
295
296 chrome::Navigate(&params);
297 manager.WaitForWillStartRequest();
298
299 browser()->tab_strip_model()->GetActiveWebContents()->Close();
300
301 manager.WaitForNavigationFinished();
302
303 histogram_tester_.ExpectTotalCount(internal::kHistogramAbortCloseBeforeCommit,
304 1);
305 }
306
307 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortMultiple) {
308 ASSERT_TRUE(embedded_test_server()->Start());
309
310 GURL url(embedded_test_server()->GetURL("/title1.html"));
311 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
312 content::TestNavigationManager manager(
313 browser()->tab_strip_model()->GetActiveWebContents(), url);
314
315 chrome::Navigate(&params);
316 manager.WaitForWillStartRequest();
317
318 GURL url2(embedded_test_server()->GetURL("/title2.html"));
319 chrome::NavigateParams params2(browser(), url2, ui::PAGE_TRANSITION_TYPED);
320 content::TestNavigationManager manager2(
321 browser()->tab_strip_model()->GetActiveWebContents(), url2);
322 chrome::Navigate(&params2);
323
324 manager2.WaitForWillStartRequest();
325 manager.WaitForNavigationFinished();
326
327 GURL url3(embedded_test_server()->GetURL("/title3.html"));
328 chrome::NavigateParams params3(browser(), url3, ui::PAGE_TRANSITION_TYPED);
329 content::TestNavigationManager manager3(
330 browser()->tab_strip_model()->GetActiveWebContents(), url3);
331 chrome::Navigate(&params3);
332
333 manager3.WaitForWillStartRequest();
334 manager2.WaitForNavigationFinished();
335
336 manager3.WaitForNavigationFinished();
337
338 histogram_tester_.ExpectTotalCount(
339 internal::kHistogramAbortNewNavigationBeforeCommit, 2);
340 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698