Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2132603002: [page_load_metrics] Add a NavigationThrottle for richer abort metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More browser tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 6 #include "base/test/histogram_tester.h"
7 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 8 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 9 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_navigator_params.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h"
9 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
10 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
15 #include "content/public/test/browser_test_utils.h"
11 #include "net/test/embedded_test_server/embedded_test_server.h" 16 #include "net/test/embedded_test_server/embedded_test_server.h"
12 17
13 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest { 18 class MetricsWebContentsObserverBrowserTest : public InProcessBrowserTest {
14 public: 19 public:
15 MetricsWebContentsObserverBrowserTest() {} 20 MetricsWebContentsObserverBrowserTest() {}
16 ~MetricsWebContentsObserverBrowserTest() override {} 21 ~MetricsWebContentsObserverBrowserTest() override {}
17 22
18 protected: 23 protected:
19 base::HistogramTester histogram_tester_; 24 base::HistogramTester histogram_tester_;
20 25
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 185
181 ui_test_utils::NavigateToURL( 186 ui_test_utils::NavigateToURL(
182 browser(), embedded_test_server()->GetURL( 187 browser(), embedded_test_server()->GetURL(
183 "/page_load_metrics/document_write_no_script.html")); 188 "/page_load_metrics/document_write_no_script.html"));
184 ui_test_utils::NavigateToURL(browser(), 189 ui_test_utils::NavigateToURL(browser(),
185 embedded_test_server()->GetURL("/title2.html")); 190 embedded_test_server()->GetURL("/title2.html"));
186 191
187 histogram_tester_.ExpectTotalCount( 192 histogram_tester_.ExpectTotalCount(
188 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0); 193 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);
189 } 194 }
195
196 // Test code that aborts provisional navigations.
197 // TODO(csharrison): Move these to unit tests once the navigation API in content
198 // properly calls NavigationHandle/NavigationThrottle methods.
199 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,
200 AbortNewNavigation) {
201 ASSERT_TRUE(embedded_test_server()->Start());
202
203 GURL url(embedded_test_server()->GetURL("/title1.html"));
204 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
205 content::TestNavigationManager manager(
206 browser()->tab_strip_model()->GetActiveWebContents(), url);
207
208 chrome::Navigate(&params);
209 manager.WaitForWillStartRequest();
210
211 GURL url2(embedded_test_server()->GetURL("/title2.html"));
212 chrome::NavigateParams params2(browser(), url2,
213 ui::PAGE_TRANSITION_FROM_ADDRESS_BAR);
214 content::TestNavigationManager manager2(
215 browser()->tab_strip_model()->GetActiveWebContents(), url2);
216 chrome::Navigate(&params2);
217
218 manager2.WaitForNavigationFinished();
219 histogram_tester_.ExpectTotalCount(
220 internal::kHistogramAbortNewNavigationBeforeCommit, 1);
221 }
222
223 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortReload) {
224 ASSERT_TRUE(embedded_test_server()->Start());
225
226 GURL url(embedded_test_server()->GetURL("/title1.html"));
227 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
228 content::TestNavigationManager manager(
229 browser()->tab_strip_model()->GetActiveWebContents(), url);
230
231 chrome::Navigate(&params);
232 manager.WaitForWillStartRequest();
233
234 chrome::NavigateParams params2(browser(), url, ui::PAGE_TRANSITION_RELOAD);
235 content::TestNavigationManager manager2(
236 browser()->tab_strip_model()->GetActiveWebContents(), url);
237 chrome::Navigate(&params2);
238
239 manager2.WaitForNavigationFinished();
240 histogram_tester_.ExpectTotalCount(
241 internal::kHistogramAbortReloadBeforeCommit, 1);
242 }
243
244 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortClose) {
245 ASSERT_TRUE(embedded_test_server()->Start());
246
247 GURL url(embedded_test_server()->GetURL("/title1.html"));
248 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
249 content::TestNavigationManager manager(
250 browser()->tab_strip_model()->GetActiveWebContents(), url);
251
252 chrome::Navigate(&params);
253 manager.WaitForWillStartRequest();
254
255 browser()->tab_strip_model()->GetActiveWebContents()->Close();
256
257 manager.WaitForNavigationFinished();
258
259 histogram_tester_.ExpectTotalCount(internal::kHistogramAbortCloseBeforeCommit,
260 1);
261 }
262
263 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AbortMultiple) {
264 ASSERT_TRUE(embedded_test_server()->Start());
265
266 GURL url(embedded_test_server()->GetURL("/title1.html"));
267 chrome::NavigateParams params(browser(), url, ui::PAGE_TRANSITION_LINK);
268 content::TestNavigationManager manager(
269 browser()->tab_strip_model()->GetActiveWebContents(), url);
270
271 chrome::Navigate(&params);
272 manager.WaitForWillStartRequest();
273
274 GURL url2(embedded_test_server()->GetURL("/title2.html"));
275 chrome::NavigateParams params2(browser(), url2, ui::PAGE_TRANSITION_TYPED);
276 content::TestNavigationManager manager2(
277 browser()->tab_strip_model()->GetActiveWebContents(), url2);
278 chrome::Navigate(&params2);
279
280 manager2.WaitForWillStartRequest();
281 manager.WaitForNavigationFinished();
282
283 GURL url3(embedded_test_server()->GetURL("/title3.html"));
284 chrome::NavigateParams params3(browser(), url3, ui::PAGE_TRANSITION_TYPED);
285 content::TestNavigationManager manager3(
286 browser()->tab_strip_model()->GetActiveWebContents(), url3);
287 chrome::Navigate(&params3);
288
289 manager3.WaitForWillStartRequest();
290 manager2.WaitForNavigationFinished();
291
292 manager3.WaitForNavigationFinished();
293
294 histogram_tester_.ExpectTotalCount(
295 internal::kHistogramAbortNewNavigationBeforeCommit, 2);
296 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698