chrome/browser/ui/cocoa/first_run_dialog.mm - Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/first_run_dialog.mm

Issue 2132593002: Remove remaining calls to deprecated MessageLoop methods on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: h264_vt_encoder_unittest.cc Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm ('k') | chrome/browser/ui/cocoa/importer/import_lock_dialog_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/first_run_dialog.mm

diff --git a/chrome/browser/ui/cocoa/first_run_dialog.mm b/chrome/browser/ui/cocoa/first_run_dialog.mm

index 0cfb84baf6b640e710a67786587101433d2c8afb..396fda51832c56499f590d165e58e42724f463b3 100644

--- a/chrome/browser/ui/cocoa/first_run_dialog.mm

+++ b/chrome/browser/ui/cocoa/first_run_dialog.mm

@@ -8,7 +8,9 @@

#import "base/mac/scoped_nsobject.h"

#include "base/memory/ref_counted.h"

#include "base/message_loop/message_loop.h"

+#include "base/run_loop.h"

#include "base/strings/sys_string_conversions.h"

+#include "base/threading/thread_task_runner_handle.h"

#include "chrome/browser/first_run/first_run.h"

#include "chrome/browser/first_run/first_run_dialog.h"

#include "chrome/browser/metrics/metrics_reporting_state.h"

@@ -144,9 +146,9 @@ bool ShowFirstRunDialog(Profile* profile) {

// Therefore the main MessageLoop is run so things work.

scoped_refptr<FirstRunShowBridge> bridge(new FirstRunShowBridge(self));

- base::MessageLoop::current()->PostTask(FROM_HERE,

- base::Bind(&FirstRunShowBridge::ShowDialog, bridge.get()));

- base::MessageLoop::current()->Run();

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

+ FROM_HERE, base::Bind(&FirstRunShowBridge::ShowDialog, bridge.get()));

+ base::RunLoop().Run();

}

- (void)show {