Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2132563003: Implement origin-based deletion for the domain reliability service. (Closed)

Created:
4 years, 5 months ago by msramek
Modified:
4 years, 5 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement origin-based deletion for the domain reliability service. BUG=589586 Committed: https://crrev.com/010756d22dac3980f53732152ab2637039206abd Cr-Commit-Position: refs/heads/master@{#406025}

Patch Set 1 #

Patch Set 2 : Updated DomainReliabilityMonitorTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -31 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 7 chunks +58 lines, -3 lines 0 comments Download
M components/domain_reliability/context_manager.h View 1 2 chunks +9 lines, -6 lines 0 comments Download
M components/domain_reliability/context_manager.cc View 1 3 chunks +22 lines, -8 lines 0 comments Download
M components/domain_reliability/monitor.h View 1 1 chunk +8 lines, -4 lines 0 comments Download
M components/domain_reliability/monitor.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/domain_reliability/monitor_unittest.cc View 1 1 chunk +55 lines, -2 lines 0 comments Download
M components/domain_reliability/service.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/domain_reliability/service.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
msramek
Hi Julia, Please have a look! Thanks, Martin
4 years, 5 months ago (2016-07-07 16:54:26 UTC) #2
Julia Tuttle
lgtm!
4 years, 5 months ago (2016-07-07 18:11:05 UTC) #3
msramek
Thanks :)
4 years, 5 months ago (2016-07-08 10:47:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132563003/1
4 years, 5 months ago (2016-07-08 10:47:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/93287)
4 years, 5 months ago (2016-07-08 11:04:38 UTC) #8
msramek
The tests were red, because I missed a unittest (I thought there must be one, ...
4 years, 5 months ago (2016-07-08 12:28:05 UTC) #10
msramek
Friendly ping :)
4 years, 5 months ago (2016-07-13 09:59:55 UTC) #11
msramek
Oh sorry, you're OOO. Well this doesn't hurry that much, so I'll just wait.
4 years, 5 months ago (2016-07-13 10:03:42 UTC) #12
Julia Tuttle
lgtm! Thanks for fixing this.
4 years, 5 months ago (2016-07-18 14:47:50 UTC) #13
msramek
Thanks again :)
4 years, 5 months ago (2016-07-18 15:52:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132563003/40001
4 years, 5 months ago (2016-07-18 15:52:47 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-18 17:33:37 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:35:53 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/010756d22dac3980f53732152ab2637039206abd
Cr-Commit-Position: refs/heads/master@{#406025}

Powered by Google App Engine
This is Rietveld 408576698