Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: src/runtime/runtime-debug.cc

Issue 2132553002: [wasm] Use handles in wasm::GetDebugInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/frames.cc ('K') | « src/frames.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-debug.cc
diff --git a/src/runtime/runtime-debug.cc b/src/runtime/runtime-debug.cc
index aa9bcb4a9d404f4fa6417fd24e23d77b0cb29aff..9db7b7f0f1ccce5bf707d01b6670e9ed31cce644 100644
--- a/src/runtime/runtime-debug.cc
+++ b/src/runtime/runtime-debug.cc
@@ -1803,8 +1803,8 @@ RUNTIME_FUNCTION(Runtime_GetWasmFunctionOffsetTable) {
CHECK(script_val->value()->IsScript());
Handle<Script> script = Handle<Script>(Script::cast(script_val->value()));
- Handle<wasm::WasmDebugInfo> debug_info(
- wasm::GetDebugInfo(script->wasm_object()), isolate);
+ Handle<wasm::WasmDebugInfo> debug_info =
+ wasm::GetDebugInfo(handle(script->wasm_object(), isolate));
Handle<FixedArray> elements = wasm::WasmDebugInfo::GetFunctionOffsetTable(
debug_info, script->wasm_function_index());
return *isolate->factory()->NewJSArrayWithElements(elements);
@@ -1818,8 +1818,8 @@ RUNTIME_FUNCTION(Runtime_DisassembleWasmFunction) {
CHECK(script_val->value()->IsScript());
Handle<Script> script = Handle<Script>(Script::cast(script_val->value()));
- Handle<wasm::WasmDebugInfo> debug_info(
- wasm::GetDebugInfo(script->wasm_object()), isolate);
+ Handle<wasm::WasmDebugInfo> debug_info =
+ wasm::GetDebugInfo(handle(script->wasm_object(), isolate));
return *wasm::WasmDebugInfo::DisassembleFunction(
debug_info, script->wasm_function_index());
}
« src/frames.cc ('K') | « src/frames.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698