Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: src/frames.cc

Issue 2132553002: [wasm] Use handles in wasm::GetDebugInfo. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime/runtime-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.cc
diff --git a/src/frames.cc b/src/frames.cc
index fbce95bec0a7f9938bf9c6b356357cb23fe1863c..d14646989ebfb71161bccd93a67a2ae53e742d1f 100644
--- a/src/frames.cc
+++ b/src/frames.cc
@@ -1434,8 +1434,8 @@ uint32_t WasmFrame::function_index() const {
}
Script* WasmFrame::script() const {
Michael Starzinger 2016/07/08 08:05:07 If {wasm::GetDebugInfo} can really trigger a GC th
- JSObject* wasm = JSObject::cast(wasm_obj());
- Handle<wasm::WasmDebugInfo> debug_info(wasm::GetDebugInfo(wasm), isolate());
+ Handle<JSObject> wasm(JSObject::cast(wasm_obj()), isolate());
+ Handle<wasm::WasmDebugInfo> debug_info = wasm::GetDebugInfo(wasm);
return wasm::WasmDebugInfo::GetFunctionScript(debug_info, function_index());
}
« no previous file with comments | « no previous file | src/runtime/runtime-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698