Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2132553002: [wasm] Use handles in wasm::GetDebugInfo. (Closed)

Created:
4 years, 5 months ago by ahaas
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use handles in wasm::GetDebugInfo. Handles are necessary in wasm::GetDebugInfo because a GC can be triggered in this function. R=titzer@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/717b2eafdd9001b19e762f6dfa972eac4d5c31ea Cr-Commit-Position: refs/heads/master@{#37601}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/frames.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M src/runtime/runtime-debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ahaas
4 years, 5 months ago (2016-07-07 13:14:31 UTC) #1
titzer
lgtm
4 years, 5 months ago (2016-07-08 07:38:06 UTC) #2
Michael Starzinger
https://codereview.chromium.org/2132553002/diff/1/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/2132553002/diff/1/src/frames.cc#newcode1436 src/frames.cc:1436: Script* WasmFrame::script() const { If {wasm::GetDebugInfo} can really trigger ...
4 years, 5 months ago (2016-07-08 08:05:07 UTC) #3
Michael Starzinger
... but this is still a good first step, so LGTM on this despite my ...
4 years, 5 months ago (2016-07-08 08:06:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132553002/1
4 years, 5 months ago (2016-07-08 08:13:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 08:23:13 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 08:24:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/717b2eafdd9001b19e762f6dfa972eac4d5c31ea
Cr-Commit-Position: refs/heads/master@{#37601}

Powered by Google App Engine
This is Rietveld 408576698