Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 213253008: Cancel drag in the folder view's AppsGridView when dragging is performed there. (Closed)

Created:
6 years, 9 months ago by jennyz
Modified:
6 years, 9 months ago
Reviewers:
xiyuan, calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Cancel drag in the folder view's AppsGridView when dragging is performed there. This cl does not directly fix crbug.com/352057, but is exposed by its related fix https://codereview.chromium.org/210583004/. BUG=352057 R=xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ui/app_list/views/contents_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jennyz
6 years, 9 months ago (2014-03-26 22:20:20 UTC) #1
xiyuan
lgtm
6 years, 9 months ago (2014-03-26 22:23:03 UTC) #2
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 9 months ago (2014-03-26 22:27:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/213253008/1
6 years, 9 months ago (2014-03-26 22:27:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 23:52:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-26 23:52:45 UTC) #6
jennyz
6 years, 9 months ago (2014-03-27 01:04:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r259760 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698