Issue 213253007: Revert of Added shortcut for NW config screen in kiosk.

Issue 213253007: Revert of Added shortcut for NW config screen in kiosk. (Closed)

Created:
6 years, 9 months ago by erikchen

Modified:
6 years, 9 months ago

Reviewers:
xiyuan, Nikita (slow), zel

CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, ygorshenin1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Added shortcut for NW config screen in kiosk. (https://codereview.chromium.org/209143002/) Reason for revert: The newly added test LaunchAppWithNetworkConfigAccelerator fails. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22616 Original issue's description: > Added a shortcut (Ctrl+Alt+N) for showing network config screen in during kiosk launch even if network connectivity is present. > > BUG=350065 > TEST=added KioskTest.LaunchAppWithNetworkConfigAccelerator > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259679 TBR=xiyuan@chromium.org,nkostylev@chromium.org,zelidrag@chromium.org NOTREECHECKS=true NOTRY=true BUG=350065 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259716

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -180 lines)			Patch
M	chrome/app/chromeos_strings.grdp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/app_mode/app_launch_utils.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/app_mode/startup_app_launcher.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/app_mode/startup_app_launcher.cc	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/chromeos/login/app_launch_controller.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/app_launch_controller.cc	View	6 chunks	+3 lines, -23 lines	0 comments	Download
M	chrome/browser/chromeos/login/kiosk_browsertest.cc	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/app_launch_splash_screen_actor.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/error_screen.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/webui_login_view.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.css	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.html	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.js	View	3 chunks	+2 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/login/display_manager.js	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc	View	6 chunks	+5 lines, -41 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

erikchen

Created Revert of Added shortcut for NW config screen in kiosk.

6 years, 9 months ago (2014-03-26 22:17:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/213253007/1

6 years, 9 months ago (2014-03-26 22:18:15 UTC) #2

Message was sent while issue was closed.

Change committed as 259716

Expand Messages | Collapse Messages