Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: media/formats/webm/webm_stream_parser.cc

Issue 213253006: MSE: Populate WebM missing duration with DefaultDuration, derived, or default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and rebased (GenerateSpliceFrame() is now disabled in WMPI/WMPA in ToT) Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/formats/webm/webm_stream_parser.h" 5 #include "media/formats/webm/webm_stream_parser.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 bytes_parsed += result; 173 bytes_parsed += result;
174 174
175 WebMTracksParser tracks_parser(log_cb_, ignore_text_tracks_); 175 WebMTracksParser tracks_parser(log_cb_, ignore_text_tracks_);
176 result = tracks_parser.Parse(cur, cur_size); 176 result = tracks_parser.Parse(cur, cur_size);
177 177
178 if (result <= 0) 178 if (result <= 0)
179 return result; 179 return result;
180 180
181 bytes_parsed += result; 181 bytes_parsed += result;
182 182
183 double timecode_scale_in_us = info_parser.timecode_scale() / 1000.0;
183 base::TimeDelta duration = kInfiniteDuration(); 184 base::TimeDelta duration = kInfiniteDuration();
184 185
185 if (info_parser.duration() > 0) { 186 if (info_parser.duration() > 0) {
186 double mult = info_parser.timecode_scale() / 1000.0; 187 int64 duration_in_us = info_parser.duration() * timecode_scale_in_us;
187 int64 duration_in_us = info_parser.duration() * mult;
188 duration = base::TimeDelta::FromMicroseconds(duration_in_us); 188 duration = base::TimeDelta::FromMicroseconds(duration_in_us);
189 } 189 }
190 190
191 const AudioDecoderConfig& audio_config = tracks_parser.audio_decoder_config(); 191 const AudioDecoderConfig& audio_config = tracks_parser.audio_decoder_config();
192 if (audio_config.is_encrypted()) 192 if (audio_config.is_encrypted())
193 FireNeedKey(tracks_parser.audio_encryption_key_id()); 193 FireNeedKey(tracks_parser.audio_encryption_key_id());
194 194
195 const VideoDecoderConfig& video_config = tracks_parser.video_decoder_config(); 195 const VideoDecoderConfig& video_config = tracks_parser.video_decoder_config();
196 if (video_config.is_encrypted()) 196 if (video_config.is_encrypted())
197 FireNeedKey(tracks_parser.video_encryption_key_id()); 197 FireNeedKey(tracks_parser.video_encryption_key_id());
198 198
199 if (!config_cb_.Run(audio_config, 199 if (!config_cb_.Run(audio_config,
200 video_config, 200 video_config,
201 tracks_parser.text_tracks())) { 201 tracks_parser.text_tracks())) {
202 DVLOG(1) << "New config data isn't allowed."; 202 DVLOG(1) << "New config data isn't allowed.";
203 return -1; 203 return -1;
204 } 204 }
205 205
206
206 cluster_parser_.reset(new WebMClusterParser( 207 cluster_parser_.reset(new WebMClusterParser(
207 info_parser.timecode_scale(), 208 info_parser.timecode_scale(),
208 tracks_parser.audio_track_num(), 209 tracks_parser.audio_track_num(),
210 tracks_parser.GetAudioDefaultDuration(timecode_scale_in_us),
209 tracks_parser.video_track_num(), 211 tracks_parser.video_track_num(),
212 tracks_parser.GetVideoDefaultDuration(timecode_scale_in_us),
210 tracks_parser.text_tracks(), 213 tracks_parser.text_tracks(),
211 tracks_parser.ignored_tracks(), 214 tracks_parser.ignored_tracks(),
212 tracks_parser.audio_encryption_key_id(), 215 tracks_parser.audio_encryption_key_id(),
213 tracks_parser.video_encryption_key_id(), 216 tracks_parser.video_encryption_key_id(),
214 log_cb_)); 217 log_cb_));
215 218
216 ChangeState(kParsingClusters); 219 ChangeState(kParsingClusters);
217 220
218 if (!init_cb_.is_null()) 221 if (!init_cb_.is_null())
219 base::ResetAndReturn(&init_cb_).Run(true, duration, false); 222 base::ResetAndReturn(&init_cb_).Run(true, duration, false);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 if (bytes_parsed <= 0) 259 if (bytes_parsed <= 0)
257 return bytes_parsed; 260 return bytes_parsed;
258 261
259 // If cluster detected, immediately notify new segment if we have not already 262 // If cluster detected, immediately notify new segment if we have not already
260 // done this. 263 // done this.
261 if (id == kWebMIdCluster && !parsing_cluster_) { 264 if (id == kWebMIdCluster && !parsing_cluster_) {
262 parsing_cluster_ = true; 265 parsing_cluster_ = true;
263 new_segment_cb_.Run(); 266 new_segment_cb_.Run();
264 } 267 }
265 268
266 const BufferQueue& audio_buffers = cluster_parser_->audio_buffers(); 269 const BufferQueue& audio_buffers = cluster_parser_->GetAudioBuffers();
267 const BufferQueue& video_buffers = cluster_parser_->video_buffers(); 270 const BufferQueue& video_buffers = cluster_parser_->GetVideoBuffers();
268 const TextBufferQueueMap& text_map = cluster_parser_->GetTextBuffers(); 271 const TextBufferQueueMap& text_map = cluster_parser_->GetTextBuffers();
272
269 bool cluster_ended = cluster_parser_->cluster_ended(); 273 bool cluster_ended = cluster_parser_->cluster_ended();
270 274
271 if ((!audio_buffers.empty() || !video_buffers.empty() || !text_map.empty()) && 275 if ((!audio_buffers.empty() || !video_buffers.empty() || !text_map.empty()) &&
272 !new_buffers_cb_.Run(audio_buffers, video_buffers, text_map)) { 276 !new_buffers_cb_.Run(audio_buffers, video_buffers, text_map)) {
273 return -1; 277 return -1;
274 } 278 }
275 279
276 if (cluster_ended) { 280 if (cluster_ended) {
277 parsing_cluster_ = false; 281 parsing_cluster_ = false;
278 end_of_segment_cb_.Run(); 282 end_of_segment_cb_.Run();
279 } 283 }
280 284
281 return bytes_parsed; 285 return bytes_parsed;
282 } 286 }
283 287
284 void WebMStreamParser::FireNeedKey(const std::string& key_id) { 288 void WebMStreamParser::FireNeedKey(const std::string& key_id) {
285 std::vector<uint8> key_id_vector(key_id.begin(), key_id.end()); 289 std::vector<uint8> key_id_vector(key_id.begin(), key_id.end());
286 need_key_cb_.Run(kWebMEncryptInitDataType, key_id_vector); 290 need_key_cb_.Run(kWebMEncryptInitDataType, key_id_vector);
287 } 291 }
288 292
289 } // namespace media 293 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698