xfa/fxfa/parser/xfa_script_resolveprocessor.h - Issue 2132513003: Cleanup redundant method names.

Unified Diff: xfa/fxfa/parser/xfa_script_resolveprocessor.h

Issue 2132513003: Cleanup redundant method names. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« xfa/fxfa/parser/xfa_script_logpseudomodel.cpp ('K') | « xfa/fxfa/parser/xfa_script_nodehelper.cpp ('k') | xfa/fxfa/parser/xfa_script_resolveprocessor.cpp » ('j') | xfa/fxfa/parser/xfa_utils_imp.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: xfa/fxfa/parser/xfa_script_resolveprocessor.h

diff --git a/xfa/fxfa/parser/xfa_script_resolveprocessor.h b/xfa/fxfa/parser/xfa_script_resolveprocessor.h

index ffcd9b44757a7c1ca1b0d661814618f61807f9d5..67abe2fc7fdd5c8fe1c5d23850b20d0f584d390d 100644

--- a/xfa/fxfa/parser/xfa_script_resolveprocessor.h

+++ b/xfa/fxfa/parser/xfa_script_resolveprocessor.h

@@ -35,44 +35,43 @@ class CXFA_ResolveProcessor {

CXFA_ResolveProcessor();

~CXFA_ResolveProcessor();

- int32_t XFA_ResolveNodes(CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_AnyChild(CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_Dollar(CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_Excalmatory(CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_NumberSign(CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_Asterisk(CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_Normal(CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_ForAttributeRs(CXFA_Object* curNode,

- CXFA_ResolveNodesData& rnd,

- const CFX_WideStringC& strAttr);

- void XFA_ResolveNode_ConditionArray(int32_t iCurIndex,

- CFX_WideString wsCondition,

- int32_t iFoundCount,

- CXFA_ResolveNodesData& rnd);

- void XFA_ResolveNode_DoPredicateFilter(int32_t iCurIndex,

- CFX_WideString wsCondition,

- int32_t iFoundCount,

- CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNodes_GetFilter(const CFX_WideStringC& wsExpression,

- int32_t nStart,

- CXFA_ResolveNodesData& rnd);

- void XFA_ResolveNode_FilterCondition(CXFA_ResolveNodesData& rnd,

- CFX_WideString wsCondition);

- int32_t XFA_ResolveNodes_PopStack(CFX_Int32Array& stack);

- void XFA_ResolveNodes_SetStylesForChild(uint32_t dwParentStyles,

- CXFA_ResolveNodesData& rnd);

- int32_t XFA_ResolveNode_SetResultCreateNode(XFA_RESOLVENODE_RS& resolveNodeRS,

- CFX_WideString& wsLastCondition);

- void XFA_ResolveNode_SetIndexDataBind(CFX_WideString& wsNextCondition,

- int32_t& iIndex,

- int32_t iCount);

+ int32_t Resolve(CXFA_ResolveNodesData& rnd);

+ int32_t GetFilter(const CFX_WideStringC& wsExpression,

+ int32_t nStart,

+ CXFA_ResolveNodesData& rnd);

+ int32_t SetResultCreateNode(XFA_RESOLVENODE_RS& resolveNodeRS,

+ CFX_WideString& wsLastCondition);

+ void SetIndexDataBind(CFX_WideString& wsNextCondition,

+ int32_t& iIndex,

+ int32_t iCount);

CXFA_NodeHelper* GetNodeHelper() { return m_pNodeHelper; }

+ int32_t m_iCurStart;

Lei Zhang 2016/07/07 19:36:18 Just add getter/setter as needed?

dsinclair 2016/07/07 19:47:49 Done.

private:

- CXFA_NodeHelper* m_pNodeHelper;

+ int32_t ResolveForAttributeRs(CXFA_Object* curNode,

+ CXFA_ResolveNodesData& rnd,

+ const CFX_WideStringC& strAttr);

+ int32_t ResolveAnyChild(CXFA_ResolveNodesData& rnd);

+ int32_t ResolveDollar(CXFA_ResolveNodesData& rnd);

+ int32_t ResolveExcalmatory(CXFA_ResolveNodesData& rnd);

+ int32_t ResolveNumberSign(CXFA_ResolveNodesData& rnd);

+ int32_t ResolveAsterisk(CXFA_ResolveNodesData& rnd);

+ int32_t ResolveNormal(CXFA_ResolveNodesData& rnd);

+ int32_t ResolvePopStack(CFX_Int32Array& stack);

+ void SetStylesForChild(uint32_t dwParentStyles, CXFA_ResolveNodesData& rnd);

- public:

- int32_t m_iCurStart;

+ void ConditionArray(int32_t iCurIndex,

+ CFX_WideString wsCondition,

+ int32_t iFoundCount,

+ CXFA_ResolveNodesData& rnd);

+ void DoPredicateFilter(int32_t iCurIndex,

+ CFX_WideString wsCondition,

+ int32_t iFoundCount,

+ CXFA_ResolveNodesData& rnd);

+ void FilterCondition(CXFA_ResolveNodesData& rnd, CFX_WideString wsCondition);

+ CXFA_NodeHelper* m_pNodeHelper;

};

#endif // XFA_FXFA_PARSER_XFA_SCRIPT_RESOLVEPROCESSOR_H_