src/debug/mirrors.js - Issue 2132493002: [runtime] Fully remove RUNTIME_ASSERT for good.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/mirrors.js

Issue 2132493002: [runtime] Fully remove RUNTIME_ASSERT for good. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-runtime-assert-robust

Patch Set: Rebased. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug/mirrors.js

diff --git a/src/debug/mirrors.js b/src/debug/mirrors.js

index 1ccb001711876ff45372baf9b4d6a1d936baca37..84ea9abb0e06e5d9fca978d54a903358b290688a 100644

--- a/src/debug/mirrors.js

+++ b/src/debug/mirrors.js

@@ -2342,6 +2342,7 @@ ScriptMirror.prototype.source = function() {

ScriptMirror.prototype.setSource = function(source) {

+ if (!IS_STRING(source)) throw MakeError(kDebugger, "Source is not a string");

%DebugSetScriptSource(this.script_, source);

};

« no previous file with comments | « src/base/logging.cc ('k') | src/runtime/runtime-strings.cc » ('j') | no next file with comments »