Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4611)

Unified Diff: chrome/browser/banners/app_banner_metrics.cc

Issue 2132483002: Add metrics for app banner preventDefault() and prompt(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_metrics.cc
diff --git a/chrome/browser/banners/app_banner_metrics.cc b/chrome/browser/banners/app_banner_metrics.cc
index f9bbd34e460afaaf89101bf17b906d6380813973..58e373d3b90f8786c20a60c933a28dcd343ea6f0 100644
--- a/chrome/browser/banners/app_banner_metrics.cc
+++ b/chrome/browser/banners/app_banner_metrics.cc
@@ -15,6 +15,7 @@ const char kInstallEventHistogram[] = "AppBanners.InstallEvent";
const char kMinutesHistogram[] =
"AppBanners.MinutesFromFirstVisitToBannerShown";
const char kUserResponseHistogram[] = "AppBanners.UserResponse";
+const char kBeforeInstallEventHistogram[] = "AppBanners.BeforeInstallEvent";
void TrackDismissEvent(int event) {
DCHECK_LT(DISMISS_EVENT_MIN, event);
@@ -48,4 +49,10 @@ void TrackUserResponse(int event) {
UMA_HISTOGRAM_SPARSE_SLOWLY(kUserResponseHistogram, event);
}
+void TrackBeforeInstallEvent(int event) {
+ DCHECK_LT(BEFORE_INSTALL_EVENT_MIN, event);
+ DCHECK_LT(event, BEFORE_INSTALL_EVENT_MAX);
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kBeforeInstallEventHistogram, event);
+}
+
} // namespace banners
« no previous file with comments | « chrome/browser/banners/app_banner_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698