Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: src/compiler/simplified-lowering.h

Issue 2132403002: [turbofan] Remove dead code from SimplifiedLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@TurboFan_CheckBounds
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_ 5 #ifndef V8_COMPILER_SIMPLIFIED_LOWERING_H_
6 #define V8_COMPILER_SIMPLIFIED_LOWERING_H_ 6 #define V8_COMPILER_SIMPLIFIED_LOWERING_H_
7 7
8 #include "src/base/flags.h"
9 #include "src/compiler/js-graph.h" 8 #include "src/compiler/js-graph.h"
10 #include "src/compiler/machine-operator.h" 9 #include "src/compiler/machine-operator.h"
11 #include "src/compiler/node.h" 10 #include "src/compiler/node.h"
12 #include "src/compiler/simplified-operator.h" 11 #include "src/compiler/simplified-operator.h"
13 12
14 namespace v8 { 13 namespace v8 {
15 namespace internal { 14 namespace internal {
16 15
17 // Forward declarations. 16 // Forward declarations.
18 class TypeCache; 17 class TypeCache;
19 18
20 19
21 namespace compiler { 20 namespace compiler {
22 21
23 // Forward declarations. 22 // Forward declarations.
24 class RepresentationChanger; 23 class RepresentationChanger;
25 class RepresentationSelector; 24 class RepresentationSelector;
26 class SourcePositionTable; 25 class SourcePositionTable;
27 26
28 class SimplifiedLowering final { 27 class SimplifiedLowering final {
29 public: 28 public:
30 enum Flag { kNoFlag = 0u, kTypeFeedbackEnabled = 1u << 0 };
31 typedef base::Flags<Flag> Flags;
32 SimplifiedLowering(JSGraph* jsgraph, Zone* zone, 29 SimplifiedLowering(JSGraph* jsgraph, Zone* zone,
33 SourcePositionTable* source_positions, 30 SourcePositionTable* source_positions);
34 Flags flags = kNoFlag);
35 ~SimplifiedLowering() {} 31 ~SimplifiedLowering() {}
36 32
37 void LowerAllNodes(); 33 void LowerAllNodes();
38 34
39 void DoJSToNumberTruncatesToFloat64(Node* node, 35 void DoJSToNumberTruncatesToFloat64(Node* node,
40 RepresentationSelector* selector); 36 RepresentationSelector* selector);
41 void DoJSToNumberTruncatesToWord32(Node* node, 37 void DoJSToNumberTruncatesToWord32(Node* node,
42 RepresentationSelector* selector); 38 RepresentationSelector* selector);
43 // TODO(turbofan): The representation can be removed once the result of the 39 // TODO(turbofan): The representation can be removed once the result of the
44 // representation analysis is stored in the node bounds. 40 // representation analysis is stored in the node bounds.
45 void DoLoadBuffer(Node* node, MachineRepresentation rep, 41 void DoLoadBuffer(Node* node, MachineRepresentation rep,
46 RepresentationChanger* changer); 42 RepresentationChanger* changer);
47 void DoStoreBuffer(Node* node); 43 void DoStoreBuffer(Node* node);
48 void DoShift(Node* node, Operator const* op, Type* rhs_type); 44 void DoShift(Node* node, Operator const* op, Type* rhs_type);
49 45
50 Flags flags() const { return flags_; }
51
52 private: 46 private:
53 JSGraph* const jsgraph_; 47 JSGraph* const jsgraph_;
54 Zone* const zone_; 48 Zone* const zone_;
55 TypeCache const& type_cache_; 49 TypeCache const& type_cache_;
56 SetOncePointer<Node> to_number_code_; 50 SetOncePointer<Node> to_number_code_;
57 SetOncePointer<Operator const> to_number_operator_; 51 SetOncePointer<Operator const> to_number_operator_;
58 Flags flags_;
59 52
60 // TODO(danno): SimplifiedLowering shouldn't know anything about the source 53 // TODO(danno): SimplifiedLowering shouldn't know anything about the source
61 // positions table, but must for now since there currently is no other way to 54 // positions table, but must for now since there currently is no other way to
62 // pass down source position information to nodes created during 55 // pass down source position information to nodes created during
63 // lowering. Once this phase becomes a vanilla reducer, it should get source 56 // lowering. Once this phase becomes a vanilla reducer, it should get source
64 // position information via the SourcePositionWrapper like all other reducers. 57 // position information via the SourcePositionWrapper like all other reducers.
65 SourcePositionTable* source_positions_; 58 SourcePositionTable* source_positions_;
66 59
67 Node* Float64Ceil(Node* const node); 60 Node* Float64Ceil(Node* const node);
68 Node* Float64Floor(Node* const node); 61 Node* Float64Floor(Node* const node);
(...skipping 19 matching lines...) Expand all
88 CommonOperatorBuilder* common() { return jsgraph()->common(); } 81 CommonOperatorBuilder* common() { return jsgraph()->common(); }
89 MachineOperatorBuilder* machine() { return jsgraph()->machine(); } 82 MachineOperatorBuilder* machine() { return jsgraph()->machine(); }
90 SimplifiedOperatorBuilder* simplified() { return jsgraph()->simplified(); } 83 SimplifiedOperatorBuilder* simplified() { return jsgraph()->simplified(); }
91 }; 84 };
92 85
93 } // namespace compiler 86 } // namespace compiler
94 } // namespace internal 87 } // namespace internal
95 } // namespace v8 88 } // namespace v8
96 89
97 #endif // V8_COMPILER_SIMPLIFIED_LOWERING_H_ 90 #endif // V8_COMPILER_SIMPLIFIED_LOWERING_H_
OLDNEW
« no previous file with comments | « src/compiler/pipeline.cc ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698