Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: pkg/compiler/lib/src/closure.dart

Issue 2132383002: Renamed isParameter to isRegularParameter. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Review response Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library closureToClassMapper; 5 library closureToClassMapper;
6 6
7 import 'common.dart'; 7 import 'common.dart';
8 import 'common/names.dart' show Identifiers; 8 import 'common/names.dart' show Identifiers;
9 import 'common/resolution.dart' show ParsingContext, Resolution; 9 import 'common/resolution.dart' show ParsingContext, Resolution;
10 import 'common/tasks.dart' show CompilerTask; 10 import 'common/tasks.dart' show CompilerTask;
(...skipping 1107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1118 assert(freeVariables.isEmpty || savedInsideClosure); 1118 assert(freeVariables.isEmpty || savedInsideClosure);
1119 for (Local freeVariable in freeVariables) { 1119 for (Local freeVariable in freeVariables) {
1120 addCapturedVariable(node, freeVariable); 1120 addCapturedVariable(node, freeVariable);
1121 useLocal(freeVariable); 1121 useLocal(freeVariable);
1122 } 1122 }
1123 } 1123 }
1124 1124
1125 visitFunctionExpression(FunctionExpression node) { 1125 visitFunctionExpression(FunctionExpression node) {
1126 Element element = elements[node]; 1126 Element element = elements[node];
1127 1127
1128 if (element.isParameter) { 1128 if (element.isRegularParameter) {
1129 // TODO(ahe): This is a hack. This method should *not* call 1129 // TODO(ahe): This is a hack. This method should *not* call
1130 // visitChildren. 1130 // visitChildren.
1131 return node.name.accept(this); 1131 return node.name.accept(this);
1132 } 1132 }
1133 1133
1134 visitInvokable(element, node, () { 1134 visitInvokable(element, node, () {
1135 // TODO(ahe): This is problematic. The backend should not repeat 1135 // TODO(ahe): This is problematic. The backend should not repeat
1136 // the work of the resolver. It is the resolver's job to create 1136 // the work of the resolver. It is the resolver's job to create
1137 // parameters, etc. Other phases should only visit statements. 1137 // parameters, etc. Other phases should only visit statements.
1138 if (node.parameters != null) node.parameters.accept(this); 1138 if (node.parameters != null) node.parameters.accept(this);
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
1189 /// 1189 ///
1190 /// Move the below classes to a JS model eventually. 1190 /// Move the below classes to a JS model eventually.
1191 /// 1191 ///
1192 abstract class JSEntity implements Entity { 1192 abstract class JSEntity implements Entity {
1193 Entity get declaredEntity; 1193 Entity get declaredEntity;
1194 } 1194 }
1195 1195
1196 abstract class PrivatelyNamedJSEntity implements JSEntity { 1196 abstract class PrivatelyNamedJSEntity implements JSEntity {
1197 Entity get rootOfScope; 1197 Entity get rootOfScope;
1198 } 1198 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698