third_party/WebKit/LayoutTests/custom-elements/imports/imports-upgrade.html - Issue 2132343002: Make Custom Elements V1 work in HTML imports documents

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/imports-upgrade.html

Issue 2132343002: Make Custom Elements V1 work in HTML imports documents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: imports-create tests checks the order of constructors Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/custom-elements/imports/imports-create.html ('K') | « third_party/WebKit/LayoutTests/custom-elements/imports/imports-define-in-import.html ('k') | third_party/WebKit/LayoutTests/custom-elements/imports/resources/import-custom.html » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link id="import1" rel="import" href="resources/import-custom.html" />

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <x-x></x-x>

	6 <script>

	7 'use strict'

	8 setup({ explicit_done: true });

	9 window.onload = function () {

	10 let reactions = [];

	11 customElements.define('x-x', class extends HTMLElement {

	12 constructor() {

	13 super();

	14 reactions.push({ type: 'constructor', element: this });

	15 }

	16 });

	17

	18 test(() => {

	19 assert_equals(reactions.length, 2);

	20 }, 'Upgrade elements in master and import');

	21

	22 let elementsInMaster = document.getElementsByTagName('x-x');

	23 let elementsInImport = import1.import.getElementsByTagName('x-x');

	24 test(() => {

	25 assert_equals(reactions[0].element, elementsInImport[0]);
	dominicc (has gone to gerrit) 2016/07/19 01:57:39 This test would be more descriptive if it had <x- This test would be more descriptive if it had <x-x id="a"> <link rel="import" href="..."> <-- contains ID c <x-x id="b"> <script>... define assert_array_equals(reactions, ... Note how I've put elements before and after the import. Then someone reading the test cant tell if upgrades happen import-first (which I think is what you have implemented here) or "flatten imports into tree order" order. The test as written isn't descriptive because both of those orders produce the same result. The same thing goes for the test above, where the call to 'define' is in the imported document.
	26 assert_equals(reactions[1].element, elementsInMaster[0]);

	27 }, 'Upgrade elements in import first');

	28

	29 done();

	30 };

	31 </script>

OLD	NEW