Make Custom Elements V1 work in HTML imports documents

third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/custom/CustomElementsRegistry.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptCustomElementDefinitionBuilder.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
@@ skipping 57 matching lines @@
     CustomElementsRegistry* registry = new CustomElementsRegistry(document);
     if (V0CustomElementRegistrationContext* v0Context = registry->v0())
         v0Context->setV1(registry);
     return registry;
 }
 
 CustomElementsRegistry::CustomElementsRegistry(Document* document)
     : m_document(document)
     , m_upgradeCandidates(new UpgradeCandidateMap())
 {
+    // !contextDocument() just for unit testing.
+    DCHECK(document == document->contextDocument()
+        || !document->contextDocument());
 }
 
 DEFINE_TRACE(CustomElementsRegistry)
 {
     visitor->trace(m_definitions);
     visitor->trace(m_document);
     visitor->trace(m_upgradeCandidates);
     visitor->trace(m_whenDefinedPromiseMap);
 }
 
@@ skipping 119 matching lines @@
 }
 
 CustomElementDefinition* CustomElementsRegistry::definitionForName(
     const AtomicString& name) const
 {
     return m_definitions.get(name);
 }
 
 void CustomElementsRegistry::addCandidate(Element* candidate)
 {
+    // !contextDocument() just for unit testing.
+    DCHECK(candidate->document().contextDocument() == m_document
+        || !candidate->document().contextDocument());
+
     const AtomicString& name = candidate->localName();
     if (nameIsDefined(name) || v0NameIsDefined(name))
         return;
     UpgradeCandidateMap::iterator it = m_upgradeCandidates->find(name);
     UpgradeCandidateSet* set;
     if (it != m_upgradeCandidates->end()) {
         set = it->value;
     } else {
         set = m_upgradeCandidates->add(name, new UpgradeCandidateSet())
             .storedValue
@@ skipping 15 matching lines @@
         return ScriptPromise::castUndefined(scriptState);
     ScriptPromiseResolver* resolver = m_whenDefinedPromiseMap.get(name);
     if (resolver)
         return resolver->promise();
     ScriptPromiseResolver* newResolver =
         ScriptPromiseResolver::create(scriptState);
     m_whenDefinedPromiseMap.add(name, newResolver);
     return newResolver->promise();
 }
 
+using ElementsInDocument = HeapVector<Member<Element>>;
+using ElementsDocumentMap = HeapHashMap<Document*, ElementsInDocument>;
+
+static void addToImports(ElementsDocumentMap& imports, Element* element)
+{
+    Document* document = &element->document();
+    const auto& it = imports.find(document);
+    ElementsInDocument* list;
+    if (it != imports.end()) {
+        list = &it->value;
+    } else {
+        list = &imports.add(document, ElementsInDocument())
+            .storedValue->value;
+    }
+    list->append(element);
+}
+
+static void collectFromImports(ElementsDocumentMap& imports, HeapVector<Member<Element>>* elements)
+{
+    for (const auto& it : imports) {
+        CustomElementUpgradeSorter sorter;
+        for (Element* element : it.value)
+            sorter.add(element);
+        sorter.sorted(elements, it.key);
+    }
+}
+
 void CustomElementsRegistry::collectCandidates(
     const CustomElementDescriptor& desc,
     HeapVector<Member<Element>>* elements)
 {
     UpgradeCandidateMap::iterator it = m_upgradeCandidates->find(desc.name());
     if (it == m_upgradeCandidates->end())
         return;
+
+    ElementsDocumentMap imports;
     CustomElementUpgradeSorter sorter;
     for (Element* element : *it.get()->value) {
         if (!element || !desc.matches(*element))
             continue;
-        sorter.add(element);
+
+        Document& document = element->document();
+        if (document == m_document) {
+            sorter.add(element);
+            continue;
+        }

[dominicc (has gone to gerrit), 2016/07/13 06:12:30]

else-if might be clearer than continues.

[kojii, 2016/07/13 06:47:16]

Done.

[kojii, 2016/07/13 06:47:16]

Done.

+
+        // Group elements by document if they are in import documents.
+        if (document.contextDocument() == m_document) {
+            addToImports(imports, element);
+            continue;
+        }
+
+        // The element has moved to other documents, ignore.
     }
 
     m_upgradeCandidates->remove(it);
+    if (!imports.isEmpty())

[dominicc (has gone to gerrit), 2016/07/13 06:12:30]

I'm not really grokking this change at this point. For each element, we grabble
through imports? Why? What if there are tons of imports?

Why can't we just define a sort order over nodes in imported documents too and
keep everything more uniform here?

[kojii, 2016/07/13 06:47:16]

I'm sorry, I can't understand what "grabble" means.

I think this code defines the order, by grouping by documents and process import
documents first.

If you're saying all these should be done hidden in CustomElementUpgradeSorter,
that I can understand. Is this what you're saying here?

+        collectFromImports(imports, elements);
     sorter.sorted(elements, m_document.get());
 }
 
 } // namespace blink