third_party/WebKit/LayoutTests/custom-elements/imports/imports-create.html - Issue 2132343002: Make Custom Elements V1 work in HTML imports documents

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/imports-create.html

Issue 2132343002: Make Custom Elements V1 work in HTML imports documents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/custom-elements/imports/imports-define-in-import.html » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 'use strict'

	6 setup({ explicit_done: true });

	7 let reactions = [];

	8 customElements.define('x-x', class extends HTMLElement {

	9 constructor() {

	10 super();

	11 reactions.push({ type: 'constructor', element: this });

	12 console.log("constructor", this);

	13 }

	14 });

	15 test(() => {

	16 assert_equals(reactions.length, 0);

	17 }, 'Should not have parsed <x-x> yet');

	18 </script>

	19

	20 <x-x></x-x>

	21

	22 <script>

	23 test(() => {

	24 assert_equals(reactions.length, 1);

	25 }, 'Parser should create custom if after define');

	26

	27 let import1 = document.createElement('link');

	28 import1.rel = 'import';

	29 import1.href = 'resources/import-custom.html';

	30 document.head.appendChild(import1);

	31

	32 import1.onload = () => {

	33 test(() => {

	34 assert_equals(reactions.length, 2);
	dominicc (has gone to gerrit) 2016/07/13 06:12:30 These presumably have to be in order. Can you push These presumably have to be in order. Can you push the actual objects and make sure they're the right ones? kojii 2016/07/13 06:47:16 The test does push the actual object. Also the oth Show quoted text On 2016/07/13 at 06:12:30, dominicc wrote: > These presumably have to be in order. Can you push the actual objects and make sure they're the right ones? The test does push the actual object. Also the other test checks the order, but no in this test because this tests "length == 1" before. I can add that to this test too. kojii 2016/07/13 07:00:13 Done in PS5. Show quoted text On 2016/07/13 at 06:47:16, kojii wrote: > On 2016/07/13 at 06:12:30, dominicc wrote: > > These presumably have to be in order. Can you push the actual objects and make sure they're the right ones? > > The test does push the actual object. Also the other test checks the order, but no in this test because this tests "length == 1" before. I can add that to this test too. Done in PS5.
	35 }, 'import should create custom if after define');
	dominicc (has gone to gerrit) 2016/07/13 06:12:30 These descriptions are cryptic; what is create cus These descriptions are cryptic; what is create custom? How is this different to imports-upgrade? (I know they're different, but you could make it easier to understand with longer, more specific file names and more specific assertions.)
	36

	37 done();

	38 };

	39 </script>

OLD	NEW