Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213233003: Show a notification when a braille display is connected. (Closed)

Created:
6 years, 9 months ago by Peter Lundblad
Modified:
6 years, 9 months ago
Reviewers:
dmazzoni, oshima
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Visibility:
Public.

Description

Show a notification when a braille display is connected. BUG=293011 R=dmazzoni@chromium.org,oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260079

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add missed override for new method in AccessibilityDelegate. #

Patch Set 3 : Remove LOGs #

Total comments: 6

Patch Set 4 : Style and const correctness fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -99 lines) Patch
M ash/accessibility_delegate.h View 1 2 3 4 chunks +6 lines, -3 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/default_accessibility_delegate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/default_accessibility_delegate.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ash/system/tray_accessibility.h View 1 2 3 4 chunks +19 lines, -2 lines 0 comments Download
M ash/system/tray_accessibility.cc View 1 2 7 chunks +55 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 5 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 5 chunks +26 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 3 chunks +2 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/system/tray_accessibility_browsertest.cc View 1 2 3 8 chunks +86 lines, -15 lines 0 comments Download
A chrome/browser/extensions/api/braille_display_private/mock_braille_controller.h View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/braille_display_private/mock_braille_controller.cc View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Peter Lundblad
6 years, 9 months ago (2014-03-26 17:50:34 UTC) #1
dmazzoni
lgtm https://codereview.chromium.org/213233003/diff/1/ash/system/tray_accessibility.cc File ash/system/tray_accessibility.cc (right): https://codereview.chromium.org/213233003/diff/1/ash/system/tray_accessibility.cc#newcode118 ash/system/tray_accessibility.cc:118: LOG(ERROR) << "Popping up " << text; // ...
6 years, 9 months ago (2014-03-26 19:02:46 UTC) #2
Peter Lundblad
dmazzoni@chromium.org writes: > lgtm > > > > > https://codereview.chromium.org/213233003/diff/1/ash/system/tray_accessibility.cc > File ash/system/tray_accessibility.cc (right): > ...
6 years, 9 months ago (2014-03-26 19:10:15 UTC) #3
Peter Lundblad
Alright, addressed the LOGs. @oshima I think this is ready for OWNERS review now if ...
6 years, 9 months ago (2014-03-26 19:26:18 UTC) #4
oshima
lgtm with nits. https://codereview.chromium.org/213233003/diff/30001/ash/accessibility_delegate.h File ash/accessibility_delegate.h (right): https://codereview.chromium.org/213233003/diff/30001/ash/accessibility_delegate.h#newcode76 ash/accessibility_delegate.h:76: virtual bool IsBrailleDisplayConnected() = 0; nit: ...
6 years, 9 months ago (2014-03-26 19:42:53 UTC) #5
Peter Lundblad
Hi, Thanks! oshima@chromium.org writes: > lgtm with nits. > > > https://codereview.chromium.org/213233003/diff/30001/ash/accessibility_delegate.h > File ash/accessibility_delegate.h ...
6 years, 9 months ago (2014-03-26 22:39:28 UTC) #6
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 9 months ago (2014-03-26 22:57:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/213233003/50001
6 years, 9 months ago (2014-03-26 22:59:12 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 05:24:17 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 05:24:18 UTC) #10
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 9 months ago (2014-03-27 15:51:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/213233003/50001
6 years, 9 months ago (2014-03-27 15:51:41 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:41:26 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=289447
6 years, 9 months ago (2014-03-27 16:41:26 UTC) #14
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 9 months ago (2014-03-27 17:01:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/213233003/50001
6 years, 9 months ago (2014-03-27 17:01:38 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 17:40:59 UTC) #17
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=58789
6 years, 9 months ago (2014-03-27 17:41:00 UTC) #18
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 9 months ago (2014-03-28 05:13:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/213233003/50001
6 years, 9 months ago (2014-03-28 05:15:28 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 06:35:05 UTC) #21
Message was sent while issue was closed. 
Change committed as 260079

Powered by Google App Engine
This is Rietveld 408576698