third_party/WebKit/LayoutTests/svg/animations/begin-use-counters.html - Issue 2132323002: Add some additional SMIL use counters

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/animations/begin-use-counters.html

Issue 2132323002: Add some additional SMIL use counters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/svg/animations/add-after-load-use-counter.html ('K') | « third_party/WebKit/LayoutTests/svg/animations/add-after-load-use-counter.html ('k') | third_party/WebKit/LayoutTests/svg/animations/end-use-counters.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <svg width="400" height="400">

	5 <rect id="target" x="10" y="10" width="80" height="80" />

	6 </svg>

	7 <script>

	8 'use strict';

	9

	10 // From UseCounter.h

	11 var SVGEventValue = 1440;

	12 var SVGSyncbaseValue = 1441;
	Mike Lawther (Google) 2016/07/13 07:30:54 nit: consider using the same names as the enum fro nit: consider using the same names as the enum from the .h file? suzyh_UTC10 (ex-contributor) 2016/07/13 23:08:07 Ditto. Show quoted text On 2016/07/13 at 07:30:54, Mike Lawther (Google) wrote: > nit: consider using the same names as the enum from the .h file? Ditto.
	13

	14 test(() => {

	15 var target = document.getElementById('target');

	16 var animation = document.createElementNS("http://www.w3.org/2000/svg", "anim ate");

	17 animation.setAttribute("begin", "5s");

	18 target.appendChild(animation);

	19 assert_false(internals.isUseCounted(document, SVGEventValue));

	20 assert_false(internals.isUseCounted(document, SVGSyncbaseValue));

	21 }, 'begin using time is not counted as event or syncbase value.');

	22

	23 test(() => {

	24 var target = document.getElementById('target');

	25 assert_false(internals.isUseCounted(document, SVGEventValue));

	26 var animation = document.createElementNS("http://www.w3.org/2000/svg", "anim ate");

	27 animation.setAttribute("begin", "target.click");

	28 target.appendChild(animation);

	29 assert_true(internals.isUseCounted(document, SVGEventValue));

	30 }, 'begin using event-value is use counted.');

	31

	32 test(() => {

	33 var target = document.getElementById('target');

	34 assert_false(internals.isUseCounted(document, SVGSyncbaseValue));

	35 var animation = document.createElementNS("http://www.w3.org/2000/svg", "anim ate");

	36 animation.setAttribute("begin", "anim.end");

	37 target.appendChild(animation);

	38 assert_true(internals.isUseCounted(document, SVGSyncbaseValue));

	39 }, 'begin using syncbase-value is use counted.');

	40

	41 </script>

OLD	NEW