third_party/WebKit/LayoutTests/svg/animations/add-after-load-use-counter.html - Issue 2132323002: Add some additional SMIL use counters

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/animations/add-after-load-use-counter.html

Issue 2132323002: Add some additional SMIL use counters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/animations/begin-use-counters.html » ('j') | third_party/WebKit/LayoutTests/svg/animations/begin-use-counters.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <svg width="400" height="400">

	5 <rect id="target" x="10" y="110" width="80" height="80">

	6 <set attributeType="XML" attributeName="x" to="210" />

	7 </rect>

	8 </svg>

	9 <script>

	10 'use strict';

	11

	12 // From UseCounter.h

	13 var SVGInsertAnimationValue = 1442;
	Mike Lawther (Google) 2016/07/13 07:30:54 nit: I'd give this the same name as from the .h fi nit: I'd give this the same name as from the .h file (ie SVGSMILElementInsertedAfterLoad), as it's a pretty good name already, and matches better with the comment on line 12. suzyh_UTC10 (ex-contributor) 2016/07/13 23:08:07 Good call, done. Show quoted text On 2016/07/13 at 07:30:54, Mike Lawther (Google) wrote: > nit: I'd give this the same name as from the .h file (ie SVGSMILElementInsertedAfterLoad), as it's a pretty good name already, and matches better with the comment on line 12. Good call, done.
	14

	15 var testHandle = async_test("SMIL element inserted after load is counted");

	16

	17 window.onload = function() {

	18 testHandle.step(function() {

	19 var animation = document.createElementNS("http://www.w3.org/2000/svg", " set");

	20 animation.setAttribute("attributeType", "XML");

	21 animation.setAttribute("attributeName", "y");

	22 animation.setAttribute("value", "310");

	23 assert_false(internals.isUseCounted(document, SVGInsertAnimationValue));

	24 target.appendChild(animation);

	25 assert_true(internals.isUseCounted(document, SVGInsertAnimationValue));

	26 });

	27 testHandle.done();

	28 };

	29

	30 </script>

OLD	NEW