Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 2132303002: X87: [builtins] Construct builtin frame in String/Number ctors. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Construct builtin frame in String/Number ctors. port d49d3864d7854ac485884bd60312bc3246edc476 (r37598) original commit message: BUG= Committed: https://crrev.com/42baff6abea3314e9e20f658d0d07ea9cb5314ec Cr-Commit-Position: refs/heads/master@{#37622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -68 lines) Patch
M src/x87/builtins-x87.cc View 13 chunks +119 lines, -68 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-07-11 01:54:56 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-07-11 03:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132303002/1
4 years, 5 months ago (2016-07-11 05:15:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 05:42:09 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 05:43:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42baff6abea3314e9e20f658d0d07ea9cb5314ec
Cr-Commit-Position: refs/heads/master@{#37622}

Powered by Google App Engine
This is Rietveld 408576698