Chromium Code Reviews

Unified Diff: chrome/app/generated_resources.grd

Issue 21323003: The UI part of search-by-image search. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: addressed avi's comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | chrome/browser/renderer_host/chrome_render_view_host_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
===================================================================
--- chrome/app/generated_resources.grd (revision 215101)
+++ chrome/app/generated_resources.grd (working copy)
@@ -787,6 +787,9 @@
<message name="IDS_CONTENT_CONTEXT_SEARCHWEBFOR" desc="The name of the Search the Web for 'string' command in the content area context menu">
&amp;Search <ph name="SEARCH_ENGINE">$1<ex>Google</ex></ph> for '<ph name="SEARCH_TERMS">$2<ex>flowers</ex></ph>'
</message>
+ <message name="IDS_CONTENT_CONTEXT_SEARCHWEBFORIMAGE" desc="The name of the Search For Image command in the content area context menu">
Kibeom Kim (inactive) 2013/08/01 22:50:56 could you add formatter_data="android_java" aft
Kibeom Kim (inactive) 2013/08/01 23:07:02 please discard this, just discussed with tedchoc@
Kibeom Kim (inactive) 2013/08/01 23:16:55 Actually, not downstream but here. <if expr="is_a
Kibeom Kim (inactive) 2013/08/01 23:18:52 Forgot to include formatter_data="android_java". T
+ &amp;Search <ph name="SEARCH_ENGINE">$1<ex>Google</ex></ph> for this image
+ </message>
<message name="IDS_CONTENT_CONTEXT_GOTOURL" desc="The name of the Go to 'url' command in the content area context menu">
&amp;Go to <ph name="URL">$1<ex>http://www.google.com/</ex></ph>
</message>
@@ -996,6 +999,9 @@
<message name="IDS_CONTENT_CONTEXT_SEARCHWEBFOR" desc="In Title Case: The name of the Search the Web for 'string' command in the content area context menu">
&amp;Search <ph name="SEARCH_ENGINE">$1<ex>Google</ex></ph> for '<ph name="SEARCH_TERMS">$2<ex>flowers</ex></ph>'
</message>
+ <message name="IDS_CONTENT_CONTEXT_SEARCHWEBFORIMAGE" desc="In Title Case: The name of the Search For Image command in the content area context menu">
Kibeom Kim (inactive) 2013/08/01 22:50:56 also here.
Kibeom Kim (inactive) 2013/08/01 23:16:55 note that not "this image" but "This Image" here.
Kibeom Kim (inactive) 2013/08/01 23:18:52 This is correct version: <if expr="is_android">
+ &amp;Search <ph name="SEARCH_ENGINE">$1<ex>Google</ex></ph> for this image
+ </message>
<message name="IDS_CONTENT_CONTEXT_GOTOURL" desc="In Title Case: The name of the Go to url for 'string' command in the content area context menu">
&amp;Go to <ph name="URL">$1<ex>http://www.google.com/</ex></ph>
</message>
« no previous file with comments | « chrome/app/chrome_command_ids.h ('k') | chrome/browser/renderer_host/chrome_render_view_host_observer.h » ('j') | no next file with comments »

Powered by Google App Engine