Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issue 21323002: Bring back setting visible viewport size based on cliprect. (Closed)

Created:
7 years, 4 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 4 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Bring back setting visible viewport size based on cliprect. This effectively reverts the functional part of r211496, since the scrollbar size calculation was incorrect. However, we no longer check that the container layer masksToBounds since it does not anymore. NOTRY=true BUG=263172 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aelias_OOO_until_Jul13
PTAL.
7 years, 4 months ago (2013-07-31 03:41:45 UTC) #1
enne (OOO)
Thanks. This seems a lot cleaner to me. lgtm.
7 years, 4 months ago (2013-07-31 17:03:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/21323002/1
7 years, 4 months ago (2013-07-31 17:31:10 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 17:44:49 UTC) #4
Message was sent while issue was closed.
Change committed as 214772

Powered by Google App Engine
This is Rietveld 408576698