Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2132273002: Change DepsUpdater.is_manual_test to check wpt_automation directory. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, josiahk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DepsUpdater.is_manual_test to check wpt_automation directory. BUG=626740 Committed: https://crrev.com/660fc948b4ac9d4ca1b7c09685f2b12f314b3ad1 Cr-Commit-Position: refs/heads/master@{#404823}

Patch Set 1 #

Patch Set 2 : Remove print statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 1 chunk +17 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
qyearsley
4 years, 5 months ago (2016-07-11 16:15:59 UTC) #2
Rick Byers
Nice, thanks! LGTM
4 years, 5 months ago (2016-07-11 20:56:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132273002/20001
4 years, 5 months ago (2016-07-11 21:41:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260313)
4 years, 5 months ago (2016-07-12 00:56:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132273002/20001
4 years, 5 months ago (2016-07-12 17:59:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 19:37:36 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 19:38:28 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/660fc948b4ac9d4ca1b7c09685f2b12f314b3ad1 Cr-Commit-Position: refs/heads/master@{#404823}
4 years, 5 months ago (2016-07-12 19:38:50 UTC) #15
Dirk Pranke
4 years, 4 months ago (2016-08-09 03:46:36 UTC) #17
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698