Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 213223005: Use the Navigator's frame in navigator.serviceWorker and associated container. (Closed)

Created:
6 years, 8 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 8 months ago
Reviewers:
kinuko
CC:
blink-reviews, Nils Barth (inactive), haraken, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Use the Navigator's frame in navigator.serviceWorker and associated container. NavigatorServiceWorker's use of CallWith=ExecutionContext meant the container was configured depending on how it was accessed: for example, navigator.serviceWorker would associate it with the frame's execution context; but iframe.contentWindow.navigator.serviceWorker, window.opener.navigator.serviceWorker, window.parent.navigator.serviceWorker, etc. would associate it with a different execution context. This change always retrieves the execution context from the frame associated with the Navigator object. Separately, the ServiceWorkerContainerClient was a supplement to the page, which meant a main frame and an iframe could end up sharing a ServiceWorkerContainerClient, violating the assumption of a 1:1 relationship between provider and client. This change associates it with the document. BUG=358979 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170641

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
PTAL
6 years, 8 months ago (2014-04-02 05:57:42 UTC) #1
kinuko
Yup this lgtm... was a bit ignorant about page:frames relationship.
6 years, 8 months ago (2014-04-02 06:19:54 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 8 months ago (2014-04-02 07:14:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/213223005/1
6 years, 8 months ago (2014-04-02 07:15:03 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 07:46:37 UTC) #5
Message was sent while issue was closed.
Change committed as 170641

Powered by Google App Engine
This is Rietveld 408576698