Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2132173002: Update some squashing tests to actually test squashing vs non-squashing behavior. (Closed)

Created:
4 years, 5 months ago by chrishtr
Modified:
4 years, 5 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update some squashing tests to actually test squashing vs non-squashing behavior. Also deflake compositing/squashing/squash-with-ancestor-blending.html. BUG=610788 Committed: https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666 Cr-Commit-Position: refs/heads/master@{#404675}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Total comments: 2

Patch Set 4 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending-expected.html View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-filter.html View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-filter-expected.html View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-mask-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-opacity.html View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-opacity-expected.html View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-reflection.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-reflection-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
chrishtr
https://codereview.chromium.org/2132173002/diff/40001/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html File third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html (right): https://codereview.chromium.org/2132173002/diff/40001/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html#newcode19 third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html:19: generateDom(); I was able to deflake by generating dom ...
4 years, 5 months ago (2016-07-09 00:01:49 UTC) #4
Xianzhu
lgtm https://codereview.chromium.org/2132173002/diff/40001/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html File third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html (right): https://codereview.chromium.org/2132173002/diff/40001/third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html#newcode19 third_party/WebKit/LayoutTests/compositing/squashing/squash-with-ancestor-blending.html:19: generateDom(); On 2016/07/09 00:01:49, chrishtr wrote: > I ...
4 years, 5 months ago (2016-07-09 02:09:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132173002/60001
4 years, 5 months ago (2016-07-09 02:09:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-09 04:10:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132173002/60001
4 years, 5 months ago (2016-07-11 15:46:55 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-11 16:50:28 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 16:50:36 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 16:52:13 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c76c6e041d1b17a721884933ebfacb1d8f6e3666
Cr-Commit-Position: refs/heads/master@{#404675}

Powered by Google App Engine
This is Rietveld 408576698