Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: blimp/client/public/BUILD.gn

Issue 2132163002: Add BlimpClientContext and factory with real and dummy implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-blimp-client-core-public-to-blimp-client
Patch Set: git merge origin/master before CQ for good measure Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/client/core/dummy_blimp_client_context.cc ('k') | blimp/client/public/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 source_set("public") { 10 # Only //chrome should ever depend on this. Code in //blimp/client/* should
11 # instead use //blimp/client/public:public_headers directly. This target
12 # differs from :public_headers by pulling in the appropriate implementation
13 # as well as the headers.
14 group("public") {
15 visibility = [ "//chrome/*" ]
16
17 deps = [
18 ":public_headers",
19 "//blimp/client/core:core_shim",
20 ]
21 }
22
23 # All code in //blimp/client/* should depend on this target instead of
24 # //blimp/client/public to ensure there are no circular dependencies or
25 # duplicate symbols regardless of whether enable_blimp is set or not.
26 source_set("public_headers") {
27 visibility = [ "//blimp/client/*" ]
28
11 sources = [ 29 sources = [
30 "blimp_client_context.h",
31 "blimp_client_context_delegate.h",
12 "blimp_contents.h", 32 "blimp_contents.h",
13 "blimp_contents_observer.h", 33 "blimp_contents_observer.h",
14 "blimp_navigation_controller.h", 34 "blimp_navigation_controller.h",
15 ] 35 ]
16 36
17 deps = [ 37 deps = [
18 "//base", 38 "//base",
39 "//components/keyed_service/core",
19 "//url", 40 "//url",
20 ] 41 ]
42
43 if (is_android) {
44 sources += [ "android/blimp_jni_registrar.h" ]
45 }
21 } 46 }
22 47
23 if (is_android) { 48 if (is_android) {
24 android_library("public_java") { 49 # Only //chrome should ever depend on this. Code in //blimp/client/* should
50 # instead use //blimp/client/public:public_headers_java directly. This target
51 # differs from :public_headers_java by pulling in the appropriate
52 # implementation as well as the headers.
53 java_group("public_java") {
54 visibility = [ "//chrome/*" ]
55
56 deps = [
57 ":public_headers_java",
58 "//blimp/client/core:core_shim_java",
59 ]
60 }
61
62 # All code in //blimp/client/* should depend on this target instead of
63 # //blimp/client/public:public_java to ensure there are no circular
64 # dependencies or duplicate files regardless of whether enable_blimp is set or
65 # not.
66 android_library("public_headers_java") {
67 visibility = [ "//blimp/client/*" ]
68
25 java_files = [ 69 java_files = [
70 "android/java/src/org/chromium/blimp_public/BlimpClientContext.java",
26 "android/java/src/org/chromium/blimp_public/BlimpContents.java", 71 "android/java/src/org/chromium/blimp_public/BlimpContents.java",
27 "android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java", 72 "android/java/src/org/chromium/blimp_public/BlimpContentsObserver.java",
28 "android/java/src/org/chromium/blimp_public/BlimpNavigationController.java ", 73 "android/java/src/org/chromium/blimp_public/BlimpNavigationController.java ",
29 "android/java/src/org/chromium/blimp_public/EmptyBlimpContentsObserver.jav a", 74 "android/java/src/org/chromium/blimp_public/EmptyBlimpContentsObserver.jav a",
30 ] 75 ]
31 } 76 }
32 } 77 }
OLDNEW
« no previous file with comments | « blimp/client/core/dummy_blimp_client_context.cc ('k') | blimp/client/public/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698