Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 213213002: Fix LoadFieldByIndex to take mutable heap-numbers into account. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nit Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2684 matching lines...) Expand 10 before | Expand all | Expand 10 after
2695 LInstruction* LChunkBuilder::DoCheckMapValue(HCheckMapValue* instr) { 2695 LInstruction* LChunkBuilder::DoCheckMapValue(HCheckMapValue* instr) {
2696 LOperand* value = UseRegisterAtStart(instr->value()); 2696 LOperand* value = UseRegisterAtStart(instr->value());
2697 LOperand* map = UseRegisterAtStart(instr->map()); 2697 LOperand* map = UseRegisterAtStart(instr->map());
2698 return AssignEnvironment(new(zone()) LCheckMapValue(value, map)); 2698 return AssignEnvironment(new(zone()) LCheckMapValue(value, map));
2699 } 2699 }
2700 2700
2701 2701
2702 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2702 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2703 LOperand* object = UseRegister(instr->object()); 2703 LOperand* object = UseRegister(instr->object());
2704 LOperand* index = UseTempRegister(instr->index()); 2704 LOperand* index = UseTempRegister(instr->index());
2705 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2705 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2706 LInstruction* result = DefineSameAsFirst(load);
2707 return AssignPointerMap(result);
2706 } 2708 }
2707 2709
2708 2710
2709 } } // namespace v8::internal 2711 } } // namespace v8::internal
2710 2712
2711 #endif // V8_TARGET_ARCH_IA32 2713 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698