Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: src/hydrogen-instructions.h

Issue 213213002: Fix LoadFieldByIndex to take mutable heap-numbers into account. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed nit Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.cc ('k') | src/ia32/lithium-codegen-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7481 matching lines...) Expand 10 before | Expand all | Expand 10 after
7492 HForInCacheArray* index_cache_; 7492 HForInCacheArray* index_cache_;
7493 }; 7493 };
7494 7494
7495 7495
7496 class HLoadFieldByIndex V8_FINAL : public HTemplateInstruction<2> { 7496 class HLoadFieldByIndex V8_FINAL : public HTemplateInstruction<2> {
7497 public: 7497 public:
7498 HLoadFieldByIndex(HValue* object, 7498 HLoadFieldByIndex(HValue* object,
7499 HValue* index) { 7499 HValue* index) {
7500 SetOperandAt(0, object); 7500 SetOperandAt(0, object);
7501 SetOperandAt(1, index); 7501 SetOperandAt(1, index);
7502 SetChangesFlag(kNewSpacePromotion);
7502 set_representation(Representation::Tagged()); 7503 set_representation(Representation::Tagged());
7503 } 7504 }
7504 7505
7505 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE { 7506 virtual Representation RequiredInputRepresentation(int index) V8_OVERRIDE {
7506 return Representation::Tagged(); 7507 return Representation::Tagged();
7507 } 7508 }
7508 7509
7509 HValue* object() { return OperandAt(0); } 7510 HValue* object() { return OperandAt(0); }
7510 HValue* index() { return OperandAt(1); } 7511 HValue* index() { return OperandAt(1); }
7511 7512
7512 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE; 7513 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
7513 7514
7514 virtual HType CalculateInferredType() V8_OVERRIDE { 7515 virtual HType CalculateInferredType() V8_OVERRIDE {
7515 return HType::Tagged(); 7516 return HType::Tagged();
7516 } 7517 }
7517 7518
7518 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex); 7519 DECLARE_CONCRETE_INSTRUCTION(LoadFieldByIndex);
7519 7520
7520 private: 7521 private:
7521 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 7522 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
7522 }; 7523 };
7523 7524
7524 7525
7525 #undef DECLARE_INSTRUCTION 7526 #undef DECLARE_INSTRUCTION
7526 #undef DECLARE_CONCRETE_INSTRUCTION 7527 #undef DECLARE_CONCRETE_INSTRUCTION
7527 7528
7528 } } // namespace v8::internal 7529 } } // namespace v8::internal
7529 7530
7530 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 7531 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/handles.cc ('k') | src/ia32/lithium-codegen-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698