LayoutTests/fast/forms/button/button-focus-by-label-click.html - Issue 21321002: Form control focus by click on a label should be handled as same as focus

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/button/button-focus-by-label-click.html

Issue 21321002: Form control focus by click on a label should be handled as same as focus (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <p>Click a label element makes an associated control focused, but it shouldn't h ave focus appearance.</p>

	4 <label style="display: block;"><button>Button</button> Label</label>

	5 <script src="../resources/common.js"></script>

	6 <script>

	7 clickElement(document.querySelector('label'));
	keishi 2013/08/01 05:39:36 clickElement clicks the center of the element. The clickElement clicks the center of the element. The button element is probably wider than the " Label" text node so wouldn't the click happen on the button element? The test should probably be clear whether it is clicking on "Button" or " Label". tkent 2013/08/01 05:48:49 That's the reason why the label element has displa Show quoted text On 2013/08/01 05:39:36, keishi1 wrote: > clickElement clicks the center of the element. The button element is probably > wider than the " Label" text node so wouldn't the click happen on the button > element? The test should probably be clear whether it is clicking on "Button" or > " Label". That's the reason why the label element has display:block. Do you think <button id=b>...</button><label for=b>...</label> is better for readability? keishi 2013/08/01 06:00:20 I see. Yes I would prefer that if possible. Show quoted text On 2013/08/01 05:48:49, tkent wrote: > On 2013/08/01 05:39:36, keishi1 wrote: > > clickElement clicks the center of the element. The button element is probably > > wider than the " Label" text node so wouldn't the click happen on the button > > element? The test should probably be clear whether it is clicking on "Button" > or > > " Label". > > That's the reason why the label element has display:block. Do you think <button > id=b>...</button><label for=b>...</label> is better for readability? > I see. Yes I would prefer that if possible. tkent 2013/08/01 06:17:27 ok, I updated the test. Show quoted text On 2013/08/01 06:00:20, keishi1 wrote: > On 2013/08/01 05:48:49, tkent wrote: > > On 2013/08/01 05:39:36, keishi1 wrote: > > > clickElement clicks the center of the element. The button element is > probably > > > wider than the " Label" text node so wouldn't the click happen on the button > > > element? The test should probably be clear whether it is clicking on > "Button" > > or > > > " Label". > > > > That's the reason why the label element has display:block. Do you think > <button > > id=b>...</button><label for=b>...</label> is better for readability? > > > I see. Yes I would prefer that if possible. ok, I updated the test.
	8 </script>

	9 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/button/button-focus-by-label-click-expected.html » ('j') | no next file with comments »