Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 2132073003: Validate cache consistency asynchronously. Compute modification times of physical files in a separa… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index 76b27ae1e9e090fcd47c92397443ea7980d8ef52..b99cec3c962d6f50e1e93839a4db7e6a9c494e40 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -372,12 +372,7 @@ class PerformAnalysisOperation extends ServerOperation {
List<ChangeNotice> notices = result.changeNotices;
// nothing to analyze
if (notices == null) {
- bool cacheInconsistencyFixed = context.validateCacheConsistency();
- if (cacheInconsistencyFixed) {
- server.addOperation(new PerformAnalysisOperation(context, true));
- return;
- }
- // analysis is done
+ server.scheduleCacheConsistencyValidation(context);
setCacheSize(context, IDLE_CACHE_SIZE);
server.sendContextAnalysisDoneNotifications(
context, AnalysisDoneReason.COMPLETE);

Powered by Google App Engine
This is Rietveld 408576698