Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2132073003: Validate cache consistency asynchronously. Compute modification times of physical files in a separa… (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Validate cache consistency asynchronously. Compute modification times of physical files in a separate isolate. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ed887c09d1d1b3c99bf56f6b9fc719808442c0be

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -95 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +43 lines, -17 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/file_system.dart View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 4 chunks +66 lines, -0 lines 1 comment Download
M pkg/analyzer/lib/src/context/context.dart View 4 chunks +82 lines, -55 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +30 lines, -8 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/resource_utils.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-08 20:25:09 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2132073003/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart File pkg/analyzer/lib/file_system/physical_file_system.dart (right): https://codereview.chromium.org/2132073003/diff/1/pkg/analyzer/lib/file_system/physical_file_system.dart#newcode318 pkg/analyzer/lib/file_system/physical_file_system.dart:318: bool _isBeenCreated = false; "_is" --> "_has" || ...
4 years, 5 months ago (2016-07-08 21:25:09 UTC) #2
scheglov
4 years, 5 months ago (2016-07-08 22:01:12 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ed887c09d1d1b3c99bf56f6b9fc719808442c0be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698