Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed PasswordStoreMac Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x.h
diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h
index a33709d92a9be3a732c03d5a3ae85d853b94576a..f6851bc79764893b154463fb6630edf85d39b2ea 100644
--- a/chrome/browser/password_manager/password_store_x.h
+++ b/chrome/browser/password_manager/password_store_x.h
@@ -69,8 +69,10 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
base::Time delete_end,
password_manager::PasswordStoreChangeList* changes) = 0;
- // Sets the 'skip_zero_click' flag to 'true' for all logins in the database.
- virtual bool DisableAutoSignInForAllLogins(
+ // Sets the 'skip_zero_click' flag to 'true' for all logins in the database
+ // that match |origin_filter|.
+ virtual bool DisableAutoSignInForOrigins(
+ const base::Callback<bool(const GURL&)>& origin_filter,
password_manager::PasswordStoreChangeList* changes) = 0;
// The three methods below overwrite |forms| with all stored credentials
@@ -116,8 +118,8 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
base::Time delete_begin,
base::Time delete_end) override;
- password_manager::PasswordStoreChangeList DisableAutoSignInForAllLoginsImpl()
- override;
+ password_manager::PasswordStoreChangeList DisableAutoSignInForOriginsImpl(
+ const base::Callback<bool(const GURL&)>& origin_filter) override;
ScopedVector<autofill::PasswordForm> FillMatchingLogins(
const autofill::PasswordForm& form) override;
bool FillAutofillableLogins(

Powered by Google App Engine
This is Rietveld 408576698