Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2401)

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed PasswordStoreMac Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_mac.cc
diff --git a/chrome/browser/password_manager/password_store_mac.cc b/chrome/browser/password_manager/password_store_mac.cc
index fb82842ddcb1241f40a1abbf3b8419c4db70ac38..b39fdef8597f972103f34f01736cd4b55299ea88 100644
--- a/chrome/browser/password_manager/password_store_mac.cc
+++ b/chrome/browser/password_manager/password_store_mac.cc
@@ -1196,16 +1196,35 @@ PasswordStoreChangeList PasswordStoreMac::RemoveLoginsSyncedBetweenImpl(
return changes;
}
-PasswordStoreChangeList PasswordStoreMac::DisableAutoSignInForAllLoginsImpl() {
- ScopedVector<PasswordForm> forms;
- PasswordStoreChangeList list;
- if (login_metadata_db_ && login_metadata_db_->GetAutoSignInLogins(&forms) &&
- login_metadata_db_->DisableAutoSignInForAllLogins()) {
- for (const auto& form : forms)
- list.push_back(PasswordStoreChange(PasswordStoreChange::UPDATE, *form));
+PasswordStoreChangeList PasswordStoreMac::DisableAutoSignInForOriginsImpl(
+ const base::Callback<bool(const GURL&)>& origin_filter) {
+ ScopedVector<autofill::PasswordForm> forms;
+ PasswordStoreChangeList changes;
+ if (!login_metadata_db_ ||
+ !login_metadata_db_->GetAutoSignInLogins(&forms)) {
+ return changes;
+ }
+
+ std::set<GURL> origins_to_update;
+ for (const auto* form : forms) {
+ if (origin_filter.Run(form->origin))
+ origins_to_update.insert(form->origin);
}
- return list;
+ std::set<GURL> origins_updated;
+ for (const GURL& origin : origins_to_update) {
+ if (login_metadata_db_->DisableAutoSignInForOrigin(origin))
+ origins_updated.insert(origin);
+ }
+
+ for (const auto* form : forms) {
+ if (origins_updated.count(form->origin)) {
+ changes.push_back(
+ PasswordStoreChange(PasswordStoreChange::UPDATE, *form));
+ }
+ }
+
+ return changes;
}
bool PasswordStoreMac::RemoveStatisticsCreatedBetweenImpl(

Powered by Google App Engine
This is Rietveld 408576698