Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2079)

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc

Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed PasswordStoreMac Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
index d892a71ac15e8c583bc03ec100847f934553cd4e..ac77b99e874fb810d4e1e4fe9a0a5b9046499253 100644
--- a/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc
@@ -13,6 +13,7 @@
#include <vector>
#include "base/bind.h"
+#include "base/callback.h"
#include "base/location.h"
#include "base/pickle.h"
#include "base/single_thread_task_runner.h"
@@ -1000,15 +1001,20 @@ TEST_P(NativeBackendKWalletTest, RemoveLoginsSyncedBetween) {
TestRemoveLoginsBetween(SYNCED);
}
-TEST_P(NativeBackendKWalletTest, DisableAutoSignInForAllLogins) {
+TEST_P(NativeBackendKWalletTest, DisableAutoSignInForOrigins) {
NativeBackendKWalletStub backend(42, desktop_env_);
EXPECT_TRUE(backend.InitWithBus(mock_session_bus_));
+ form_isc_.skip_zero_click = false;
form_google_.skip_zero_click = false;
BrowserThread::PostTask(
BrowserThread::DB, FROM_HERE,
base::Bind(base::IgnoreResult(&NativeBackendKWallet::AddLogin),
+ base::Unretained(&backend), form_isc_));
+ BrowserThread::PostTask(
+ BrowserThread::DB, FROM_HERE,
+ base::Bind(base::IgnoreResult(&NativeBackendKWallet::AddLogin),
base::Unretained(&backend), form_google_));
RunDBThread();
@@ -1022,8 +1028,11 @@ TEST_P(NativeBackendKWalletTest, DisableAutoSignInForAllLogins) {
PasswordStoreChangeList changes;
BrowserThread::PostTaskAndReplyWithResult(
BrowserThread::DB, FROM_HERE,
- base::Bind(&NativeBackendKWallet::DisableAutoSignInForAllLogins,
- base::Unretained(&backend), &changes),
+ base::Bind(&NativeBackendKWallet::DisableAutoSignInForOrigins,
+ base::Unretained(&backend),
+ base::Bind(&GURL::operator==,
+ base::Unretained(&form_google_.origin)),
+ &changes),
base::Bind(&CheckPasswordChangesWithResult, &expected_changes, &changes));
RunDBThread();
@@ -1031,6 +1040,9 @@ TEST_P(NativeBackendKWalletTest, DisableAutoSignInForAllLogins) {
forms.push_back(&form_google_);
ExpectationArray expected;
expected.push_back(make_pair(std::string(form_google_.signon_realm), forms));
+ forms.clear();
+ forms.push_back(&form_isc_);
+ expected.push_back(make_pair(std::string(form_isc_.signon_realm), forms));
CheckPasswordForms("Chrome Form Data (42)", expected);
}

Powered by Google App Engine
This is Rietveld 408576698