Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed PasswordStoreMac Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
index 6875891b2e52234ab187f5d7ddccf976b1a0b8ab..5f0d40ba9ff4dbc3ae7a36eb1f9d0fc3cc949259 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
@@ -1177,7 +1177,7 @@ TEST_F(NativeBackendGnomeTest, RemoveLoginsSyncedBetween) {
CheckRemoveLoginsBetween(SYNCED);
}
-TEST_F(NativeBackendGnomeTest, DisableAutoSignInForAllLogins) {
+TEST_F(NativeBackendGnomeTest, DisableAutoSignInForOrigins) {
NativeBackendGnome backend(42);
backend.Init();
form_google_.skip_zero_click = false;
@@ -1204,20 +1204,25 @@ TEST_F(NativeBackendGnomeTest, DisableAutoSignInForAllLogins) {
PasswordStoreChangeList expected_changes;
expected_changes.push_back(
PasswordStoreChange(PasswordStoreChange::UPDATE, form_facebook_));
- expected_changes.push_back(
- PasswordStoreChange(PasswordStoreChange::UPDATE, form_google_));
PasswordStoreChangeList changes;
BrowserThread::PostTaskAndReplyWithResult(
BrowserThread::DB, FROM_HERE,
- base::Bind(&NativeBackendGnome::DisableAutoSignInForAllLogins,
- base::Unretained(&backend), &changes),
+ base::Bind(&NativeBackendGnome::DisableAutoSignInForOrigins,
+ base::Unretained(&backend),
+ base::Bind(&GURL::operator==,
+ base::Unretained(&form_facebook_.origin)),
+ &changes),
base::Bind(&CheckPasswordChangesWithResult, &expected_changes, &changes));
RunBothThreads();
EXPECT_EQ(2u, mock_keyring_items.size());
- for (const auto& item : mock_keyring_items)
- CheckUint32Attribute(&item, "should_skip_zero_click", 1);
+ CheckStringAttribute(
+ &mock_keyring_items[0], "origin_url", form_google_.origin.spec());
+ CheckUint32Attribute(&mock_keyring_items[0], "should_skip_zero_click", 0);
+ CheckStringAttribute(
+ &mock_keyring_items[1], "origin_url", form_facebook_.origin.spec());
+ CheckUint32Attribute(&mock_keyring_items[1], "should_skip_zero_click", 1);
}
TEST_F(NativeBackendGnomeTest, ReadDuplicateForms) {

Powered by Google App Engine
This is Rietveld 408576698