chrome/browser/browsing_data/browsing_data_remover_unittest.cc - Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 2132063002: Implement origin-based deletion for password manager's auto-signin bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed PasswordStoreMac Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.cc ('k') | chrome/browser/password_manager/native_backend_gnome_x.h » ('j') | chrome/browser/password_manager/password_store_x_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc

index 0084c25ea4bebd6759fab493af9e3228ce5dfa0d..9567c8ea6d3b38656bac5cfcea0bb2591df87612 100644

--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc

@@ -2384,8 +2384,12 @@ TEST_F(BrowsingDataRemoverTest, RemovePasswordsByOrigin) {

TEST_F(BrowsingDataRemoverTest, DisableAutoSignIn) {

RemovePasswordsTester tester(GetProfile());

+ base::Callback<bool(const GURL&)> empty_filter =

+ BrowsingDataFilterBuilder::BuildNoopFilter();

- EXPECT_CALL(*tester.store(), DisableAutoSignInForAllLoginsImpl())

+ EXPECT_CALL(

+ *tester.store(),

+ DisableAutoSignInForOriginsImpl(ProbablySameFilter(empty_filter)))

.WillOnce(Return(password_manager::PasswordStoreChangeList()));

BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,

@@ -2394,10 +2398,14 @@ TEST_F(BrowsingDataRemoverTest, DisableAutoSignIn) {

TEST_F(BrowsingDataRemoverTest, DisableAutoSignInAfterRemovingPasswords) {

RemovePasswordsTester tester(GetProfile());

+ base::Callback<bool(const GURL&)> empty_filter =

+ BrowsingDataFilterBuilder::BuildNoopFilter();

EXPECT_CALL(*tester.store(), RemoveLoginsByURLAndTimeImpl(_, _, _))

.WillOnce(Return(password_manager::PasswordStoreChangeList()));

- EXPECT_CALL(*tester.store(), DisableAutoSignInForAllLoginsImpl())

+ EXPECT_CALL(

+ *tester.store(),

+ DisableAutoSignInForOriginsImpl(ProbablySameFilter(empty_filter)))

.WillOnce(Return(password_manager::PasswordStoreChangeList()));

BlockUntilBrowsingDataRemoved(browsing_data::EVERYTHING,