Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2132043002: Set translation of toolbar buttons on Url Animations. (Closed)

Created:
4 years, 5 months ago by PEConn
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set translation of toolbar buttons on Url Animations. This is a refinement of https://codereview.chromium.org/2121283002/ , which behaves correctly when url focus animations occur when the new tab page is partially scrolled. BUG=623885 Committed: https://crrev.com/a53cd10e4514d39102713e77bd9fa56ed2c9d15b Cr-Commit-Position: refs/heads/master@{#404409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
PEConn
PTAL
4 years, 5 months ago (2016-07-08 15:46:11 UTC) #3
Bernhard Bauer
LGTM, but can you update the description to explain what additional issue this fixes?
4 years, 5 months ago (2016-07-08 15:50:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132043002/1
4 years, 5 months ago (2016-07-08 15:52:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 16:44:20 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 16:47:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a53cd10e4514d39102713e77bd9fa56ed2c9d15b
Cr-Commit-Position: refs/heads/master@{#404409}

Powered by Google App Engine
This is Rietveld 408576698