Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2132003002: [chrome.displaySource] Use InterfaceProvider instead of ServiceRegistry. (Closed)

Created:
4 years, 5 months ago by e_hakkinen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Use InterfaceProvider instead of ServiceRegistry. ServiceRegistry has been eliminated and cannot thus be used any more. BUG=242107, 623393 Committed: https://crrev.com/2f8915cbdc7fb808044917dde83b80460fc1b123 Cr-Commit-Position: refs/heads/master@{#405063}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M extensions/renderer/api/display_source/wifi_display/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_session.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
e_hakkinen
PTAL.
4 years, 5 months ago (2016-07-08 14:35:13 UTC) #2
Mikhail
lgtm, thanks!
4 years, 5 months ago (2016-07-11 08:41:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132003002/1
4 years, 5 months ago (2016-07-11 15:09:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/33504) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-11 15:11:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132003002/20001
4 years, 5 months ago (2016-07-12 07:10:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/215890)
4 years, 5 months ago (2016-07-12 07:20:11 UTC) #12
e_hakkinen
+@jam: extensions/renderer/api/display_source/wifi_display/DEPS: "+services/shell/public/cpp"
4 years, 5 months ago (2016-07-12 07:22:47 UTC) #14
jam
lgtm
4 years, 5 months ago (2016-07-12 16:20:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132003002/20001
4 years, 5 months ago (2016-07-12 18:30:48 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261408)
4 years, 5 months ago (2016-07-12 23:07:09 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2132003002/20001
4 years, 5 months ago (2016-07-13 06:30:01 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 07:07:54 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 07:08:01 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 07:09:33 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f8915cbdc7fb808044917dde83b80460fc1b123
Cr-Commit-Position: refs/heads/master@{#405063}

Powered by Google App Engine
This is Rietveld 408576698