Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2131973002: sandwich: Handle 200 responses with no data. (Closed)

Created:
4 years, 5 months ago by gabadie
Modified:
4 years, 5 months ago
Reviewers:
pasko
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandwich: Handle 200 responses with no data. Before sandwich was asserting that the request encoded_data_length > 0. But it turn out that encoded_data_length does not include the response headers' length. As a result, this assertion was failing on some website doing XHR requests that were returning 200 response. This CL fixes this issue by correctly computing the total number of byte transfered back to chrome with GetResponseTransportLength(), including the response headers size. BUG=582080 Committed: https://crrev.com/2dad1bfcf999e58230aabcba1e75b5e994b31fcc Cr-Commit-Position: refs/heads/master@{#404415}

Patch Set 1 #

Patch Set 2 : Rebase for landing #

Patch Set 3 : Remove unfortunate dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M tools/android/loading/request_track.py View 5 chunks +6 lines, -10 lines 0 comments Download
M tools/android/loading/sandwich_prefetch.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
gabadie
4 years, 5 months ago (2016-07-08 13:42:23 UTC) #2
pasko
lgtm, thank you
4 years, 5 months ago (2016-07-08 15:08:08 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2134763002 Patch 1). Please resolve the dependency and ...
4 years, 5 months ago (2016-07-08 15:19:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2131973002/40001
4 years, 5 months ago (2016-07-08 15:24:54 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-08 16:49:01 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 16:52:07 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2dad1bfcf999e58230aabcba1e75b5e994b31fcc
Cr-Commit-Position: refs/heads/master@{#404415}

Powered by Google App Engine
This is Rietveld 408576698