chrome/browser/resources/settings/settings_page/settings_router.js - Issue 2131953002: Site Settings Desktop: Implement protocol handler section.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_router.js

Issue 2131953002: Site Settings Desktop: Implement protocol handler section. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | chrome/browser/resources/settings/settings_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_router.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_router.js b/chrome/browser/resources/settings/settings_page/settings_router.js

index cf987729e2bfd677309fd865ec477f71a459f761..d26933e73018a81a7c08b9a040b9f1d8c298584a 100644

--- a/chrome/browser/resources/settings/settings_page/settings_router.js

+++ b/chrome/browser/resources/settings/settings_page/settings_router.js

@@ -283,22 +283,28 @@ Polymer({

subpage: ['site-settings', 'site-settings-category-images'],

{

- url: '/siteSettings/keygen',

+ url: '/siteSettings/handlers',

page: 'advanced',

section: 'privacy',

- subpage: ['site-settings', 'site-settings-category-keygen'],

+ subpage: ['site-settings', 'protocol-handlers'],

{

- url: '/siteSettings/location',

+ url: '/siteSettings/javascript',

page: 'advanced',

section: 'privacy',

- subpage: ['site-settings', 'site-settings-category-location'],

+ subpage: ['site-settings', 'site-settings-category-javascript'],

{

- url: '/siteSettings/javascript',

+ url: '/siteSettings/keygen',

page: 'advanced',

section: 'privacy',

- subpage: ['site-settings', 'site-settings-category-javascript'],

+ subpage: ['site-settings', 'site-settings-category-keygen'],

+ },

+ {

+ url: '/siteSettings/location',

+ page: 'advanced',

+ section: 'privacy',

+ subpage: ['site-settings', 'site-settings-category-location'],

{

url: '/siteSettings/microphone',

@@ -380,24 +386,24 @@ Polymer({

'site-details'],

{

- url: '/siteSettings/keygen/details',

+ url: '/siteSettings/javascript/details',

page: 'advanced',

section: 'privacy',

- subpage: ['site-settings', 'site-settings-category-keygen',

+ subpage: ['site-settings', 'site-settings-category-javascript',

'site-details'],

{

- url: '/siteSettings/location/details',

+ url: '/siteSettings/keygen/details',

page: 'advanced',

section: 'privacy',

- subpage: ['site-settings', 'site-settings-category-location',

+ subpage: ['site-settings', 'site-settings-category-keygen',

'site-details'],

{

- url: '/siteSettings/javascript/details',

+ url: '/siteSettings/location/details',

page: 'advanced',

section: 'privacy',

- subpage: ['site-settings', 'site-settings-category-javascript',

+ subpage: ['site-settings', 'site-settings-category-location',

'site-details'],

{