components/ntp_snippets/content_suggestions_provider.h - Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2131943002: Change NTPSnippetsService to implement ContentSuggestionsProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neuerservice2

Patch Set: Only notify category status change if actually changed Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/content_suggestions_category_status.h ('k') | components/ntp_snippets/ntp_snippets_service.h » ('j') | components/ntp_snippets/ntp_snippets_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/content_suggestions_provider.h

diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h

index 93872f5843a8214d2b835e810e05c558c44f6435..e406cfe4497dc415ae24fcf9e04f07e5d45cbb6b 100644

--- a/components/ntp_snippets/content_suggestions_provider.h

+++ b/components/ntp_snippets/content_suggestions_provider.h

@@ -78,6 +78,8 @@ class ContentSuggestionsProvider {

// Fetches the image for the suggestion with the given ID and returns it

// through the callback. This fetch may occur locally or from the internet.

+ // If that suggestion doesn't exist, doesn't have an image or if the fetch

+ // fails, the callback gets a null image.

virtual void FetchSuggestionImage(const std::string& suggestion_id,

const ImageFetchedCallback& callback) = 0;