DescriptionRevert of Replace string::find(prefix) == 0 pattern with base::StartsWith(). (patchset #2 id:20001 of https://codereview.chromium.org/2121513002/ )
Reason for revert:
Bisect believes that this CL caused the Win builder to break.
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2267
https://build.chromium.org/p/chromium/builders/Win/builds/45048
For context see:
https://bugs.chromium.org/p/chromium/issues/detail?id=626539
Original issue's description:
> Replace string::find(prefix) == 0 pattern with base::StartsWith().
>
> base::StartsWith() should be O(|prefix|) whereas string::find() is
> pretty bad, O(|string| * |prefix|).
>
> TBR=jam@chromium.org
> BUG=None
> Test=None, internal cleanup.
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
>
> Committed: https://crrev.com/53bfbe932191085b5d69f824a9923bccc26d58dc
> Cr-Commit-Position: refs/heads/master@{#404307}
TBR=thestig@chromium.org,lazyboy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Committed: https://crrev.com/f635836294b0221de8531e3ab3720d7fc18e65cd
Cr-Commit-Position: refs/heads/master@{#404341}
Patch Set 1 #Messages
Total messages: 9 (3 generated)
|