Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 213193011: Correctly OOM in the CEntryStub after retries. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Correctly OOM in the CEntryStub after retries. This fixes a bug introduced in r20179. R=jkummerow@chromium.org BUG=356211 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20292

Patch Set 1 #

Total comments: 4

Patch Set 2 : moved to debug-only as discussed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +25 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 9 months ago (2014-03-27 08:53:59 UTC) #1
Jakob Kummerow
LGTM https://codereview.chromium.org/213193011/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/213193011/diff/1/test/cctest/test-heap.cc#newcode3913 test/cctest/test-heap.cc:3913: // We should have ran into an out ...
6 years, 9 months ago (2014-03-27 09:05:21 UTC) #2
Yang
Addressed comments. Committing. https://codereview.chromium.org/213193011/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://codereview.chromium.org/213193011/diff/1/test/cctest/test-heap.cc#newcode3913 test/cctest/test-heap.cc:3913: // We should have ran into ...
6 years, 9 months ago (2014-03-27 09:26:36 UTC) #3
Yang
6 years, 9 months ago (2014-03-27 09:27:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698