Source/core/html/HTMLMediaElement.cpp - Issue 213193010: Restore the HTMLVideoElement-specific prefixed fullscreen API behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 213193010: Restore the HTMLVideoElement-specific prefixed fullscreen API behind a flag (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: add test Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index f5fb8f9311ddbe67a339b11b7c983bc1d9e04ec9..b027b138187af813fe690c5b5a2af81613f3c960 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3189,6 +3189,14 @@ void HTMLMediaElement::enterFullscreen()

FullscreenElementStack::from(document()).requestFullScreenForElement(this, 0, FullscreenElementStack::ExemptIFrameAllowFullScreenRequirement);

}

+void HTMLMediaElement::exitFullscreen()

+ WTF_LOG(Media, "HTMLMediaElement::exitFullscreen");

+ if (document().settings() && document().settings()->fullScreenEnabled() && isFullscreen())

+ FullscreenElementStack::from(document()).webkitCancelFullScreen();

eseidel 2014/03/27 16:54:18 Do you mean to call the webkit version?

philipj_slow 2014/03/27 18:58:31 It's the only one there is :)

void HTMLMediaElement::didBecomeFullscreenElement()

{

if (hasMediaControls())

« Source/core/frame/UseCounter.cpp ('K') | « Source/core/html/HTMLMediaElement.h ('k') | Source/core/html/HTMLVideoElement.h » ('j') | Source/core/html/HTMLVideoElement.h » ('J')