Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4406)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 213193007: Simplifying launcher handling by removing an unnecessary data structure and some functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
index 78fd95fd4d5bc37cff487f1d8ff120bbd5eedeb7..e0bdadcce9d73d2e0145d4725a4c563e4ebd9c91 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
@@ -263,10 +263,6 @@ class ChromeLauncherController : public ash::ShelfDelegate,
// user is not allowed to modify the auto-hide behavior.
void ToggleShelfAutoHideBehavior(aura::Window* root_window);
- // The tab no longer represents its previously identified application.
- void RemoveTabFromRunningApp(content::WebContents* tab,
- const std::string& app_id);
-
// Notify the controller that the state of an non platform app's tabs
// have changed,
void UpdateAppState(content::WebContents* contents, AppState app_state);
@@ -414,8 +410,6 @@ class ChromeLauncherController : public ash::ShelfDelegate,
friend class LauncherPlatformAppBrowserTest;
typedef std::map<ash::ShelfID, LauncherItemController*> IDToItemControllerMap;
- typedef std::list<content::WebContents*> WebContentsList;
- typedef std::map<std::string, WebContentsList> AppIDToWebContentsListMap;
typedef std::map<content::WebContents*, std::string> WebContentsToAppIDMap;
// Remembers / restores list of running applications.
@@ -464,8 +458,10 @@ class ChromeLauncherController : public ash::ShelfDelegate,
// Sets both of auto-hide behavior and alignment from prefs.
void SetShelfBehaviorsFromPrefs();
- // Returns the most recently active web contents for an app.
- content::WebContents* GetLastActiveWebContents(const std::string& app_id);
+ // Returns the shelf item status for the given |app_id|, which can be either
+ // STATUS_ACTIVE (if the app is active), STATUS_RUNNING (if there is such an
+ // app) or STATUS_CLOSED.
+ ash::ShelfItemStatus GetAppState(const::std::string& app_id);
// Creates an app launcher to insert at |index|. Note that |index| may be
// adjusted by the model to meet ordering constraints.
@@ -548,9 +544,6 @@ class ChromeLauncherController : public ash::ShelfDelegate,
IDToItemControllerMap id_to_item_controller_map_;
- // Maintains activation order of web contents for each app.
- AppIDToWebContentsListMap app_id_to_web_contents_list_;
-
// Direct access to app_id for a web contents.
WebContentsToAppIDMap web_contents_to_app_id_;

Powered by Google App Engine
This is Rietveld 408576698